Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pipeline that validates builds that touch features.xml #12573

Merged
merged 8 commits into from
Feb 25, 2022

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Feb 24, 2022

This is intended to be a PR triggered build that only runs when
features.xml has been touched, to validate that the disabled features do
not cause compilation errors.

This is intended to be a PR triggered build that only runs when
features.xml has been touched, to validate that the disabled features do
not cause compilation errors.
@DHowett
Copy link
Member Author

DHowett commented Feb 25, 2022

Build is failing because Branding "Dev" should be no-op but it isn't. :|

src/features.xml Outdated
@@ -76,3 +76,4 @@
</alwaysEnabledBrandingTokens>
</feature>
</featureStaging>
<!-- revert this commit, you are testing features.xml changes triggering a build... -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup ;P

This reverts commit 43541b2.
@DHowett DHowett merged commit 24a030f into main Feb 25, 2022
@DHowett DHowett deleted the dev/duhowett/try-feature-build-CI branch February 25, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants