Add a --elevate flag

[zadjii-msft]

To match the arg in #12137.

--elevate will manually elevate the profile.

--no-elevate will override a elevate: true in the profile with false.

So now you can wt --elevate cmd and it'll do what you think

• I work here
• Tests added
• need to update docs

[carlos-zamora]

@zadjii-msft Curious, what happens when somebody puts --elevate and --no-elevate together?

[zadjii-msft]

dont merge this quite yet

[zadjii-msft]

void AppHost::_HandleCommandlineArgs()
{
    std::vector<winrt::hstring> args;
    _buildArgsFromCommandline(args);
    std::wstring cwd{ wil::GetCurrentDirectoryW<std::wstring>() };

    Remoting::CommandlineArgs eventArgs{ { args }, { cwd } };
>    _windowManager.ProposeCommandline(eventArgs);

    _shouldCreateWindow = _windowManager.ShouldCreateWindow();
    if (!_shouldCreateWindow)

If the Terminal isn't already running, and you have a saved layout, then this line right here crashes with a RPC_S_CALL_FAILED. Presumably the window manager is never set up, or something weird. I'll look into it.

[zadjii-msft]

Okay before I lose it

• wt.exe A spawns, with --elevate
• It determines that it should create a window, because it had a new-tab ation
• It's the monarch, so it finds that it needs to spawn other processes to handle the PersistedWindowLayouts
• wt B spawns
• wt A spawns elevate-shim to elevate its profile
• at this point, wt A dies. It didn't have any tabs, so it immediately exits.
• wt B asks the WindowManager, who in turn asks the Monarch, if it should create a window. Problem is, A is still closing, or closed right in time for B to not become the monarch. So the _windowManager.ProposeCommandline call explodes (in the restored peasant)

[zadjii-msft]

Ho boy, this just got interesting. Consider:

wtd --elevate ; --elevate

you'd assume that would spawn two tabs elevated (in the same window), even with glomming turned off. That's not what would happen. We'd spawn one elevate-shim per newTab action, resulting in two elevated windows.

May have to reconsider this entirely. Might have to become a root-level parameter, to affect the entire commandline. E.g. "run this commandline in and elevated wt"

[DHowett]

I'll block you just in case

[zadjii-msft]

Ah butts okay. I definitely need to turn this into a top-level flag, not a new-tab level one. Plus, there's some other bugs that needs bits and pieces from this WIP branch, regardless of this feature getting added.

I'm going to just close this for now, and file proper issues for both these to keep me honest.