Use the correct background color when copying to clipboard #11991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Dec 20, 2021
ghost
requested review from
miniksa,
carlos-zamora,
DHowett,
leonMSFT,
PankajBhojwani and
lhecker
ghost
added
Area-Output
DHowett
approved these changes
Jan 3, 2022
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
added
the
zPreview-Service-Queued-1.13
DHowett
pushed a commit
that referenced
this pull request
Jan 21, 2022
When copying content from the terminal to the clipboard (with formatting), a default background color needs to be set to fill the unused area of the pasted block. Prior to this PR, that color was not correctly set, so the pasted content did not match what was seen on screen. Windows Terminal previously used the default background from the initial color scheme, so it didn't take palette changes into account. OpenConsole did use the active default color, but didn't take the reverse screen mode into account, so could end up using the foreground rather than the background color. In both case I've changed the code to lookup the runtime colors in the same way that renderer does, so they should now match what is seen on screen. I've manually confirmed that the background color is now correctly set when copying from both Windows Terminal and OpenConsole. Closes #11988 (cherry picked from commit b61b24e)
DHowett
removed
the
zPreview-Service-Queued-1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying content from the terminal to the clipboard (with
formatting), a default background color needs to be set to fill the
unused area of the pasted block. Prior to this PR, that color was not
correctly set, so the pasted content did not match what was seen on
screen.
Windows Terminal previously used the default background from the initial
color scheme, so it didn't take palette changes into account.
OpenConsole did use the active default color, but didn't take the
reverse screen mode into account, so could end up using the foreground
rather than the background color.
In both case I've changed the code to lookup the runtime colors in the
same way that renderer does, so they should now match what is seen on
screen.
Validation Steps Performed
I've manually confirmed that the background color is now correctly set
when copying from both Windows Terminal and OpenConsole.
Closes #11988