Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _OpenSettingsUI to OpenSettingsUI #11686

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update _OpenSettingsUI to OpenSettingsUI #11686

merged 1 commit into from
Nov 4, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Nov 4, 2021 •
edited
Loading

Summary of the Pull Request

#11404 changed _OpenSettingsUI to OpenSettingsUI in TerminalPage, but there is still one leftover reference to _OpenSettingsUI. This commit updates that.

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

Can actually build main now

zadjii-msft
zadjii-msft approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How tf did this even build successfully?

DHowett
DHowett approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. how?

@DHowett DHowett merged commit 4241d1c into main Nov 4, 2021
@DHowett DHowett deleted the dev/pabhoj/fix_terminal_page branch November 4, 2021 19:49
@serd2011
Copy link
Contributor

serd2011 commented Nov 5, 2021

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Line 3361 in a89c3e2

_OpenSettingsUI();

this was added in #11491 so it wasn't there then #11404 was build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PankajBhojwani @serd2011 @DHowett @zadjii-msft