Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to format the error message with an UNSIGNED int #11667

Merged
1 commit merged into from
Nov 3, 2021
Merged

Make sure to format the error message with an UNSIGNED int #11667

1 commit merged into from
Nov 3, 2021

Conversation

zadjii-msft
Copy link
Member

Closes #11556
image

@ghost ghost added Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Nov 1, 2021
@skyline75489
Copy link
Collaborator

I’m no English expert but, you sure about “ UNISGNED” in the title? 👀

@zadjii-msft zadjii-msft changed the title Make sure to format the error message with an UNISGNED int Make sure to format the error message with an UNSIGNED int Nov 3, 2021
@zadjii-msft zadjii-msft added AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off labels Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@miniksa
Copy link
Member

miniksa commented Nov 3, 2021

Thanks @zadjii-msft for fixing my oops.

@ghost ghost merged commit 8826cc0 into main Nov 3, 2021
@ghost ghost deleted the dev/migrie/b/11556-un-signed branch November 3, 2021 22:27
DHowett pushed a commit that referenced this pull request Dec 13, 2021
@zadjii-msft @DHowett
Make sure to format the error message with an UNSIGNED int (#11667)
217196e 
Closes #11556
![image](https://user-images.githubusercontent.com/18356694/139715591-b18ef7c1-2967-42a5-9528-2522220aa177.png)

(cherry picked from commit 8826cc0)
@ghost
Copy link

ghost commented Dec 14, 2021

🎉Windows Terminal Preview v1.12.3472.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 14, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error codes should show unsigned
4 participants
@zadjii-msft @skyline75489 @miniksa @DHowett