Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve conhost CPU usage during text selection #11634

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Improve conhost CPU usage during text selection #11634

merged 1 commit into from
Oct 28, 2021

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Oct 27, 2021

During text selection we redraw the window every time the cursor moves by a pixel.
This commit changes it so that it only updates once the selection actually changes.

This is an offshoot from #11623.

Validation Steps Performed

  • Text selection continues to work in DxEngine and AtlasEngine ✔️
  • Reduction in redraws ✔️

DHowett
DHowett approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUH. I suspect that this was just an oops.

@DHowett DHowett added the Needs-Second It's a PR that needs another sign-off label Oct 27, 2021
@lhecker lhecker added Area-Performance Performance-related issue Product-Conhost For issues in the Console codebase labels Oct 28, 2021
@lhecker lhecker merged commit 5bc094e into main Oct 28, 2021
@lhecker lhecker deleted the dev/lhecker/rendering-selection-perf branch October 28, 2021 12:08
@ghost
Copy link

ghost commented Feb 3, 2022

🎉Windows Terminal Preview v1.13.10336.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Performance Performance-related issue Needs-Second It's a PR that needs another sign-off Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhecker @DHowett @zadjii-msft