Dismiss any open content dialog when window is moved #11485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
lhecker
approved these changes
Oct 12, 2021
DHowett
added
the
zStable-Service-Queued-1.12
DHowett
approved these changes
Oct 12, 2021
DHowett
added
the
AutoMerge
|
Thanks for doing this! |
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
PankajBhojwani
removed
the
zStable-Service-Queued-1.12
PankajBhojwani
pushed a commit
that referenced
this pull request
Oct 13, 2021
## Summary of the Pull Request When the window moves, hide any visible content dialog (only one can be shown at a time) and ensure its associated async operation is terminated. #10922 dismisses any open popups when the window is moved or any scroll viewer scrolls. However, if you just close a Popup from the UI tree, the async operation associated to a ContentDialog (started with `dialog.ShowAsync`) does not terminate. The dialog lock that prevents opening multiple dialogs at the same time is not released, and no further dialog can be shown. Explicitly dismissing the only visible ContentDialog using its `Hide` method terminates the operation. ## Validation Steps Performed Manual tests, open up dialogs and move the window (like in #11425) References #10922 Closes #11425
PankajBhojwani
pushed a commit
that referenced
this pull request
Oct 13, 2021
## Summary of the Pull Request When the window moves, hide any visible content dialog (only one can be shown at a time) and ensure its associated async operation is terminated. #10922 dismisses any open popups when the window is moved or any scroll viewer scrolls. However, if you just close a Popup from the UI tree, the async operation associated to a ContentDialog (started with `dialog.ShowAsync`) does not terminate. The dialog lock that prevents opening multiple dialogs at the same time is not released, and no further dialog can be shown. Explicitly dismissing the only visible ContentDialog using its `Hide` method terminates the operation. ## Validation Steps Performed Manual tests, open up dialogs and move the window (like in #11425) References #10922 Closes #11425
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When the window moves, hide any visible content dialog (only one can be shown at a time) and ensure its associated async operation is terminated.
#10922 dismisses any open popups when the window is moved or any scroll viewer scrolls. However, if you just close a Popup from the UI tree, the async operation associated to a ContentDialog (started with
dialog.ShowAsync) does not terminate. The dialog lock that prevents opening multiple dialogs at the same time is not released, and no further dialog can be shown.Explicitly dismissing the only visible ContentDialog using its
Hidemethod terminates the operation.Validation Steps Performed
Manual tests, open up dialogs and move the window (like in #11425)
References #10922
Closes #11425