Wire up RadioButtons as groups in UIA #11442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-Accessibility
carlos-zamora
approved these changes
Oct 6, 2021
|
FYI: Verified this works as expected using NVDA |
ghost
requested review from
miniksa,
DHowett,
leonMSFT,
PankajBhojwani and
lhecker
DHowett
approved these changes
Oct 7, 2021
|
notes from body- Validation Steps Performed
|
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
added
zPreview-Service-Queued-1.13
DHowett
removed
the
zPreview-Service-Queued-1.13
PankajBhojwani
added
zStable-Service-Queued-1.12
PankajBhojwani
pushed a commit
that referenced
this pull request
Oct 15, 2021
I thought that microsoft/microsoft-ui-xaml#3183 might just fix this for us, but it didn't. We've got our RadioButton's all up in SettingsContainers, so they all think they're `AutomationProperties.AccessibilityView="Raw"` for some reason. If you simply add the `Content` to these, then they all end up correct in Accessibility Insights * [x] Will take care of #11248 but I can't be the one to close it. * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated (cherry picked from commit bc4f410)
|
🎉 Handy links: |
|
🎉 Handy links: |
12 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that microsoft/microsoft-ui-xaml#3183 might just fix this for us, but it didn't. We've got our RadioButton's all up in SettingsContainers, so they all think they're
AutomationProperties.AccessibilityView="Raw"for some reason. If you simply add theContentto these, then they all end up correct in Accessibility InsightsPR Checklist