Try to persist the Pane's working directory if we know what it is.

[Rosefield]

Summary of the Pull Request

Try to save the working directory if we know what it is (just copied what was done in duplicating a pane). I overlooked this in my original implementation that always used the settings StartingDirectory.

References

#9800

PR Checklist

• Closes #xxx
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated.
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tried setting the working directory using the OSC 9;9 escape and confirmed that the directory saves correctly.

[zadjii-msft]

this is a really cool idea, I love it

[lhecker]

You can prevent the double-COM-call with

Suggested change

	if (!_control.WorkingDirectory().empty())
	{
	args.StartingDirectory(_control.WorkingDirectory());
	}
	if (const auto path = _control.WorkingDirectory(); !path.empty())
	{
	args.StartingDirectory(path);
	}

I love the syntax... it strongly reminds me of Go.

[lhecker]

That commit message made me genuinely laugh aloud. 😄

To be fair in Go their use is a bit more prevalent as the language lacks sum types (just like C++, but their tuples are way more ergonomic, so...).
So you often see tuples being returned of the (T, bool) (aka std::pair<T, bool>) kind and you get code like this:

if value, found := myHashMap[foo]; found {
    ...
}

But I still find it useful in C++, since you never know if a getter is a trivial or - for the lack of better words - a "computing" one and I'm trying to proactively avoid hitting issues with the latter kind. Please feel free to disagree in reviews though. :)

[Rosefield]

I was completely ok with the operator bool things since I'm so used to writing if let Some(x) = foo() in rust. Rust recently approved if let chains as a feature so I'll have to adapt to the new landscape regardless. Its all just sugar around scoping anyways 🤷

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download