Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialisation of findMatch action #11233

Merged
1 commit merged into from
Sep 15, 2021
Merged

Fix serialisation of findMatch action #11233

1 commit merged into from
Sep 15, 2021

Conversation

ianjoneill
Copy link
Contributor

@ianjoneill ianjoneill commented Sep 15, 2021 •
edited
Loading

Summary of the Pull Request

Fixes the serialisation of the findMatch action so that the direction is stored.

PR Checklist

  • Closes More detailed error on keybinding errors #11225
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Added a test and tested manually.

@ianjoneill
Copy link
Contributor Author

For whatever reason the local settings model tests have decided to stop working on my machine with this error:

Summary of Errors Outside of Tests:
    Error: TAEF: [HRESULT: 0x80070005] A failure occurred while preparing to run tests in 'SettingsModel.LocalTests.dll'. (Failed to load "F:\windows-terminal\bin\x64\Release\TestHostApp\SettingsModel.LocalTests.dll" or one of its dependencies.)

The DLL definitely exists at that location...

PS F:\windows-terminal> ls F:\windows-terminal\bin\x64\Release\TestHostApp\SettingsModel.LocalTests.dll

    Directory: F:\windows-terminal\bin\x64\Release\TestHostApp

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          15/09/2021    08:51        2057216 SettingsModel.LocalTests.dll

I've added a test and am fairly sure it should work, but can't confirm due to the above.

@zadjii-msft
Copy link
Member

For whatever reason the local settings model tests have decided to stop working on my machine with this error:

Yea, that happens sometimes. These tests are tenuous at best. Sometimes it works to totally clean and rebuild all the Terminal projects.
image

which admittedly, would take a while, but might fix the test deployment.

zadjii-msft
zadjii-msft approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW okay, what a silly typo. Thanks!

@zadjii-msft
Copy link
Member

but doesn't improve the error message - should another issue be opened for that?

Meh - I'm tempted to say close that one and open a new one, but also I feel like we've got something similar already hiding on the backlog

@ianjoneill
Copy link
Contributor Author

Tests still error out after a rebuild of all the terminal projects 😢

I've updated the PR description to close #11225.

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Sep 15, 2021
carlos-zamora
carlos-zamora approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I wonder what happened here. All the other ToJson seem fine. Thanks for doing this!

@carlos-zamora carlos-zamora added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. AutoMerge Marked for automatic merge by the bot when requirements are met labels Sep 15, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 46 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@carlos-zamora
Copy link
Member

@msftbot merge this in 5 minutes

@ghost
Copy link

ghost commented Sep 15, 2021

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 15 Sep 2021 17:59:54 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 121116c into microsoft:main Sep 15, 2021
miniksa pushed a commit that referenced this pull request Sep 27, 2021
@ianjoneill @miniksa
Fix serialisation of findMatch action (#11233)
39a5b27 
## Summary of the Pull Request
Fixes the serialisation of the findMatch action so that the direction is stored.

## PR Checklist
* [x] Closes #11225
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Validation Steps Performed
Added a test and tested manually.
miniksa pushed a commit that referenced this pull request Sep 27, 2021
@ianjoneill @miniksa
Fix serialisation of findMatch action (#11233)
120bb8e 
## Summary of the Pull Request
Fixes the serialisation of the findMatch action so that the direction is stored.

## PR Checklist
* [x] Closes #11225
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Validation Steps Performed
Added a test and tested manually.
@ghost
Copy link

ghost commented Oct 4, 2021

🎉Windows Terminal v1.10.2714.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 4, 2021
Closed
@ghost
Copy link

ghost commented Oct 4, 2021

🎉Windows Terminal Preview v1.11.2731.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett DHowett removed zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. labels Oct 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More detailed error on keybinding errors
4 participants
@ianjoneill @zadjii-msft @carlos-zamora @DHowett