-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first pane movement for MoveFocus/SwapPane. #11044
Conversation
Oh my gosh, I finally understand! You might have just revolutionized my workflow, too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly all the rest of the code other than this one localization thing is great. If the loc issue isn't actually an issue, then Dustin can feel free to dismiss me if this gests ✔️'s while I'm out
… cannot be assumed everywhere.
src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
The diff is certainly smaller if you don't try to refactor anything :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, and additionally for the loc changes/unchanges!
@msftbot merge this in 2 minutes |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
This commit adds the ability to target the first pane in the tree, always. I wasn't able to find an existing issue for this, it is just a personal feature for me. I won't be heartbroken if it does not get merged. As motivation, I frequently have setups where the thing I am primarily working on is a large pane on the left and everything else is in smaller panes positioned elsewhere. I like to have one hotkey where I can go to any pane and then make it the "primary" pane if I am changing what I am working on or need to focus on another set of code/documentation/etc. ## Validation Steps Performed Confirmed that the move focus and swap pane variants both affect the correct pane. (cherry picked from commit 07dc060)
Hey @Rosefield, I'm writing up the release notes right now and you've earned yourself an entire section. In addition to your github username, is there any particular name you'd like me to use to credit you? I know you have your first/last on your profile, but I didn't want to just pull them without asking 😄 |
I think my name, Schuyler Rosefield, is fine to use. Thanks for asking! |
🎉 Handy links: |
🎉 Handy links: |
This commit adds the ability to target the first pane in the tree,
always.
I wasn't able to find an existing issue for this, it is just a personal
feature for me. I won't be heartbroken if it does not get merged.
As motivation, I frequently have setups where the thing I am primarily
working on is a large pane on the left and everything else is in smaller
panes positioned elsewhere. I like to have one hotkey where I can go to
any pane and then make it the "primary" pane if I am changing what I am
working on or need to focus on another set of code/documentation/etc.
Validation Steps Performed
Confirmed that the move focus and swap pane variants both affect the
correct pane.