Don't scroll vertically on horizontal scroll motions #10979
Conversation
ghost
added
Area-Input
|
|
||
| // GH#10329 - we don't need to handle horizontal scrolls. Only vertical ones. | ||
| // So filter out the horizontal ones. | ||
| if (point.Properties().IsHorizontalMouseWheel()) |
There was a problem hiding this comment.
Should it call args.Handled() though?
There was a problem hiding this comment.
I suspect that since we are not handling it, we should not mark it handled. Somebody else might want it 😄
DHowett
added
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
requested review from
miniksa,
carlos-zamora,
leonMSFT,
PankajBhojwani and
lhecker
| { | ||
| return; | ||
| } | ||
|
|
||
| auto result = _interactivity.MouseWheel(ControlKeyStates{ args.KeyModifiers() }, |
There was a problem hiding this comment.
actually, quick question: it looks like this'll suppress the _core->SendMouseEvent in ControlInteractivity, is that ok? We don't want the VT mouse mode data anymore?
There was a problem hiding this comment.
not for horizontal wheel we don't.
## Summary of the Pull Request Pretty straightforward. Check if the scroll event is a horizontal movement. If it is, ignore it. We don't have a horizontal scrollbar. ## References * obviously, revisit this if we ever do #1860 ## PR Checklist * [x] Closes #10329 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * scrolled ↑/↓ with slaptop trackpad: terminal scrolls. * scrolled ←/→ with slaptop trackpad: terminal doesn't scroll. * Scrolling _slightly more vertically than horizontally_ still scrolls. * Scrolling _slightly more horizontally than vertically_ doesn't scroll.
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
Summary of the Pull Request
Pretty straightforward. Check if the scroll event is a horizontal movement. If it is, ignore it. We don't have a horizontal scrollbar.
References
PR Checklist
Validation Steps Performed