Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus-tab --previous/next to ignore tab switcher order #10947

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Fix focus-tab --previous/next to ignore tab switcher order #10947

merged 3 commits into from
Aug 19, 2021

Conversation

Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Aug 15, 2021 •
edited by DHowett
Loading

When creating startupAction use TabSwitcherMode::Disabled in action args
to disable the tab switcher and prevent MRU logic to be applied.

Closes #10070

@ghost ghost added Area-Commandline wt.exe's commandline arguments Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Aug 15, 2021
@Don-Vito
Copy link
Contributor Author

Found no documentation to update: while -t is documented, -p, -n seem not to be. Am I missing something?

zadjii-msft
zadjii-msft approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nit is adding a comment on why we need to do this. Otherwise, this is a very clever solution!

src/cascadia/TerminalApp/AppCommandlineArgs.cpp Show resolved Hide resolved
@zadjii-msft
Copy link
Member

Found no documentation to update: while -t is documented, -p, -n seem not to be. Am I missing something?

Nah, we just don't always remember to update docs when we add features. We try to, but sometimes we forget ¯\_(ツ)_/¯

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Aug 18, 2021
leonMSFT
leonMSFT approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@leonMSFT leonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 😄

@DHowett @zadjii-msft
Update src/cascadia/TerminalApp/AppCommandlineArgs.cpp
49e14fb 
Co-authored-by: Mike Griese <migrie@microsoft.com>
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 19, 2021
DHowett
DHowett approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a beauty. Thanks!

@ghost
Copy link

ghost commented Aug 19, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett merged commit 46fd7ca into microsoft:main Aug 19, 2021
@DHowett
Copy link
Member

DHowett commented Aug 19, 2021

admin override: Not gonna spin the CI for a comment change

@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonMSFT leonMSFT leonMSFT approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Commandline wt.exe's commandline arguments AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The nextTab and prevTab actions do not work correctly when initiated via wt.exe or the command palette
4 participants
@Don-Vito @zadjii-msft @DHowett @leonMSFT