Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracelogging for drag&drop on the new tab button #10726

Merged
1 commit merged into from
Jul 20, 2021

Conversation

zadjii-msft
Copy link
Member

As discussed in team sync. Is this a mysterious dark pattern we didn't know about?

@ghost ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 20, 2021
@DHowett
Copy link
Member

DHowett commented Jul 20, 2021

If we want to go 100% we have to call it "darg and dorp"

@zadjii-msft zadjii-msft changed the title Add tracelogging for darg&drop on the new tab button Add tracelogging for darg&dorp on the new tab button Jul 20, 2021
@zadjii-msft zadjii-msft changed the title Add tracelogging for darg&dorp on the new tab button Add tracelogging for drag&drop on the new tab button Jul 20, 2021
@zadjii-msft zadjii-msft added the Gathering-Data We'd like to gather telemetry to influence our decision label Jul 20, 2021
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 20, 2021
@ghost
Copy link

ghost commented Jul 20, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 27 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@zadjii-msft
Copy link
Member Author

@msftbot merge this in 1 minute

@ghost
Copy link

ghost commented Jul 20, 2021

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 20 Jul 2021 16:19:22 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 5f2ac4e into main Jul 20, 2021
@ghost ghost deleted the dev/migrie/f/10721-research-drag-drop-tabs branch July 20, 2021 16:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Gathering-Data We'd like to gather telemetry to influence our decision Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find out how often people drag & drop on the '+' button
3 participants