Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow
ThrottledFunc
to work on different types of dispatcher #10187Allow
ThrottledFunc
to work on different types of dispatcher #10187Changes from all commits
e4478ee
400b35f
42b970b
4578c13
d8cc047
21a97b6
2e861d8
e20caae
d667f3b
62cbf30
445bdf6
1376721
a1ce7cb
03fb764
5e7d270
6e031e5
47410c9
0869456
dace0c4
12b78f5
e340fe9
b7b23a8
086710a
21a6370
4efdf39
59e911d
6f07004
ff3b808
559d1de
804a114
0f0af03
95300d4
1de9485
1bc27d0
3cace60
265bd9f
c8a2957
074f67c
5a0840a
b8158d4
4e7a500
f5665c5
056c354
e643885
33653e0
326cf08
a765769
3d59a67
a4be792
cf15df7
bcce581
a6099fb
f9b4216
f43f897
122b9a3
a7ff38f
3dbac4a
b8fa11a
a93b10b
8baa4f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I understand it correctly, this starts a throttled func to throw an
CursorPositionChanged
event every 100ms, right? ButTermControl
also got a_tsfTryRedrawCanvas
which only triggers the update every 100ms. Now it's only updating every 200-300ms (depending on the race between the two timers). Shouldn't we remove either of the two throttled funcs then?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so you have a point here. I'm gonna keep the throttling on the core side, not the control side. The Core will want to throttle how often it hops across the COM boundary to tell the UI to update. The UI doesn't care so much - it should just update whenever the Core tells it to.