Clear all state tracking nested commands when switching command mode #10164
Conversation
ghost
added
Area-CmdPal
DHowett
added
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 48 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this in 2 minutes |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
…10164) Went for option 2 proposed here: #10140 (comment). Disabling back space in the nested entry didn't felt as the nicest solution. Instead now all state that keeps track of nested commands is cleared when switching beteen modes. ## Validation Steps Performed - Validated the specified issue is fixed by this change:. now after entering a sub command and hitting backspace the palette no longer shows the sub command item (here `< Select color scheme...` ). - Validated that switching between all modes (command line, actions, tab search & tab switch) still work as expected. - Validated as well that all modes still work as expected. Didn't add unit tests, but happy to try that out if this would be required. Closes #10140 (cherry picked from commit dd348dc)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
DHowett
removed
the
zPreview-Service-Queued-1.13
Went for option 2 proposed here:
#10140 (comment).
Disabling back space in the nested entry didn't felt as the nicest
solution. Instead now all state that keeps track of nested commands is
cleared when switching beteen modes.
Validation Steps Performed
entering a sub command and hitting backspace the palette no longer
shows the sub command item (here
< Select color scheme...).search & tab switch) still work as expected.
Didn't add unit tests, but happy to try that out if this would be
required.
Closes #10140