Add support for focusPane action, focus-pane subcommand
#10142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Commandline
DHowett
reviewed
May 20, 2021
DHowett
approved these changes
May 20, 2021
ghost
requested review from
miniksa,
carlos-zamora,
leonMSFT,
PankajBhojwani and
lhecker
lhecker
approved these changes
May 21, 2021
| // Make sure to use _FocusFirstChild here - that'll properly update the | ||
| // focus if we're in startup. | ||
| _FocusFirstChild(); | ||
| return true; |
There was a problem hiding this comment.
If this returns, you don't need the else.
DHowett
reviewed
May 21, 2021
DHowett
reviewed
May 21, 2021
|
@msftbot merge this in 10 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
🎉 Handy links: |
This was referenced May 25, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds support for the
focusPaneaction, and thefocus-panesubcommand. These allow the user to focus a pane by it's ID.focusPaneaccepts anid, identifying the id of the pane to focus.focus-pane,fprequires the parameter--target,-tto ID the pane it's going to focus.PR Checklist
focus-panesubcommand #5464Detailed Description of the Pull Request / Additional comments
The ID isn't totally useful right now, since users can't see them. But they're there, and used in-order. This is just slightly more ergonomic for complicated commandlines than
mf up; mf leftValidation Steps Performed
Tested in command palette
Tested a variety of commandlines.
wtd -w 0 mf down ; spandwtd -w 0 fp -t 1 ; spgave me special difficulty.