-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This fixes summoning _quake as the MRU window #10108
Conversation
@@ -308,7 +308,7 @@ namespace winrt::Microsoft::Terminal::Remoting::implementation | |||
// actually on the current desktop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the method description
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Oh, the bot got hung up because of spellchecking. I'll manually merge. |
🎉 Handy links: |
🎉 Handy links: |
Summary of the Pull Request
This fixes a bug where if you had the
_quake
window open, and you tried toglobalSummon
it (not with thequakeMode
action, but just with a plain-oldglobalSummon
to activate the MRU window), we'd create a new window instead of just summoning the_quake
window.References
_quake
window from glomming #9956PR Checklist
Detailed Description of the Pull Request / Additional comments
It's basically a one-line fix, I just had to update the function signature for
_getMostRecentPeasantID
to allow us to use it differently for glomming vs summoning. When glomming,ignoreQuakeWindow
should be true. When summoning,ignoreQuakeWindow
should be false.