Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPF] Allows setting the WPF control background when setting the terminal theme #10026

Merged
1 commit merged into from
May 4, 2021
Merged

[WPF] Allows setting the WPF control background when setting the terminal theme #10026

1 commit merged into from
May 4, 2021

Conversation

javierdlg
Copy link
Member

@javierdlg javierdlg commented May 3, 2021 •
edited by DHowett
Loading

When syncing terminals across users (i.e. Liveshare shared terminals),
the terminal size is synced. This leads to having unused space around
the terminal which is the same color as the terminal's background
causing confusion as to what space is usable within the terminal.

Instead this change allows consumers to set the background color of the
control, separate from the terminal renderer's background, which makes
it easier to identify the edges of the terminal.

@javierdlg javierdlg added the Area-WPFControl Things related to the WPF version of the TermControl label May 3, 2021
@javierdlg javierdlg added this to the Terminal v1.9 milestone May 3, 2021
@javierdlg javierdlg assigned miniksa and unassigned miniksa May 3, 2021
@javierdlg javierdlg requested a review from miniksa May 3, 2021 18:11
zadjii-msft
zadjii-msft approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@javierdlg javierdlg requested a review from DHowett May 3, 2021 20:34
@javierdlg
Copy link
Member Author

@DHowett would it be possible to get a release with this change? We'd like to include it in our 16.10 release for this month.

@DHowett
Copy link
Member

DHowett commented May 3, 2021

@DHowett Dustin Howett FTE would it be possible to get a release with this change? We'd like to include it in our 16.10 release for this month.

This fix has existed for ~3 hours -- give it some time 😄

What's your deadline look like?

@javierdlg
Copy link
Member Author

I noticed that 1.9 is slated for May 30th, but I'm hoping we can get a release this week or early next? Hopefully I'm not crossing wires by pushing for a release.

@javierdlg
Copy link
Member Author

@DHowett, chatted with Tina and we're okay with this shipping with 1.9 at the end of May. So disregard my previous comment.

@DHowett DHowett added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels May 4, 2021
@DHowett
Copy link
Member

DHowett commented May 4, 2021

screenshots moved from commit body

Examples

Old:
image

New:
image

Old:
image

New:
image

Validation Steps Performed

Manual validation using Visual Studio 2019

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 4, 2021
@ghost
Copy link

ghost commented May 4, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 31414aa into main May 4, 2021
@ghost ghost deleted the dev/jadelaga/ExternalBackgroundColor branch May 4, 2021 21:18
@zadjii-msft zadjii-msft mentioned this pull request May 6, 2021
Closed
6 tasks
@DHowett DHowett removed the zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. label May 14, 2021
DHowett pushed a commit that referenced this pull request May 14, 2021
@javierdlg @DHowett
[WPF] Allows setting the WPF control background when setting the term…
2db6967 
…inal theme (#10026)

When syncing terminals across users (i.e. Liveshare shared terminals),
the terminal size is synced. This leads to having unused space around
the terminal which is the same color as the terminal's background
causing confusion as to what space is usable within the terminal.

Instead this change allows consumers to set the background color of the
control, separate from the terminal renderer's background, which makes
it easier to identify the edges of the terminal.

(cherry picked from commit 31414aa)
DHowett pushed a commit that referenced this pull request May 14, 2021
@javierdlg @DHowett
[WPF] Allows setting the WPF control background when setting the term…
ba07f65 
…inal theme (#10026)

When syncing terminals across users (i.e. Liveshare shared terminals),
the terminal size is synced. This leads to having unused space around
the terminal which is the same color as the terminal's background
causing confusion as to what space is usable within the terminal.

Instead this change allows consumers to set the background color of the
control, separate from the terminal renderer's background, which makes
it easier to identify the edges of the terminal.

(cherry picked from commit 31414aa)
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal v1.8.1444.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label May 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

Assignees
No one assigned
Labels
Area-WPFControl Things related to the WPF version of the TermControl AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
Terminal v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@javierdlg @DHowett @carlos-zamora @zadjii-msft @miniksa