Fix dropdown showing in up direction #10009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
zadjii-msft
approved these changes
May 3, 2021
It does |
DHowett
added
zPreview-Service-Queued-1.13
DHowett
approved these changes
May 4, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
removed
the
zStable-Service-Queued-1.12
DHowett
pushed a commit
that referenced
this pull request
May 14, 2021
## Summary of the Pull Request Let the dropdown menu open downwards if there's enough space, when clicking on the down arrow. ## PR Checklist * [X] Closes #8924 * [X] CLA signed. ## Detailed Description of the Pull Request / Additional comments Set the placement of the flyout to BottomEdgeAlignedLeft, as was done when opening the menu from the key binding. ## Validation Steps Performed Manual tests (cherry picked from commit 2b4c20b)
DHowett
pushed a commit
that referenced
this pull request
May 14, 2021
## Summary of the Pull Request Let the dropdown menu open downwards if there's enough space, when clicking on the down arrow. ## PR Checklist * [X] Closes #8924 * [X] CLA signed. ## Detailed Description of the Pull Request / Additional comments Set the placement of the flyout to BottomEdgeAlignedLeft, as was done when opening the menu from the key binding. ## Validation Steps Performed Manual tests (cherry picked from commit 2b4c20b)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
DHowett
removed
the
zPreview-Service-Queued-1.13
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Let the dropdown menu open downwards if there's enough space, when clicking on the down arrow.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Set the placement of the flyout to BottomEdgeAlignedLeft, as was done when opening the menu from the key binding.
Validation Steps Performed
Manual tests