Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting UI Localization issue (Japanese) #9846

Closed
noriokaki opened this issue Apr 16, 2021 · 11 comments · Fixed by #12505
Closed

Setting UI Localization issue (Japanese) #9846

noriokaki opened this issue Apr 16, 2021 · 11 comments · Fixed by #12505
Assignees
@lhecker
Labels
Area-Localization Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
22H2

Comments

@noriokaki
Copy link

Windows Terminal version (or Windows build number)

1.7.1033.0

Other Software

No response

Steps to reproduce

open setting UI

Expected Behavior

No response

Actual Behavior

image

"役職" is probably an error in the name of the "タブタイトル名"(tab title name).

image

I think "透明化" (transparency) or "透過"(translucent) would be better than "アクリル"(acrylic).
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 16, 2021
@skyline75489
Copy link
Collaborator

Thanks for the feedback! Would you mind making a more detailed chart from this? It would help us improve the localization.

See #9238 and #9328 for reference.

@noriokaki
Copy link
Author

@skyline75489
Thanks for your response.

key Recommendation
Profile_TabTitle.Header タブタイトル名
Profile_AcrylicOpacity.Header 不透明度
Profile_UseAcrylic.Header 透明化を有効にする
Profile_AcrylicHeader.Text 透明化

@skyline75489
Copy link
Collaborator

We actually have a tracking issue for "traditional transparency" which is #603, so I would suggest keeping the 'acrylic' term in the translation to avoid confusion in the future.

Feel free to list other imperfections, if you can find them 😄

@noriokaki
Copy link
Author

I agreed about the acrylic.

key Recommendation
Profile_TabTitle.Header タブタイトル名
Profile_AcrylicOpacity.Header アクリルの不透明度
Profile_UseAcrylic.Header アクリル透明化を有効にする
Profile_AcrylicHeader.Text アクリル透明化
Globals_TabWidthMode.HelpText コンパクトは、フォーカスされていないタブをアイコンのサイズに縮小します。
Globals_TabWidthModeEqual.Content 均等

@zadjii-msft zadjii-msft added Area-Localization Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Apr 16, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 16, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 16, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 29, 2021
@skyline75489
Copy link
Collaborator

/cc @lhecker for localization improvement.

@lhecker lhecker self-assigned this Jul 23, 2021
@lhecker
Copy link
Member

lhecker commented Sep 20, 2021

Tracked as MSFT:36323577.

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@lhecker
Copy link
Member

lhecker commented Feb 9, 2022 •
edited
Loading

The following strings where fixed:

  • Profile_TabTitle.Header
  • Globals_TabWidthMode.HelpText
  • Globals_TabWidthModeEqual.Content

There's an ongoing discussion regarding the translation for "acrylic" internally in MSFT:36776499.
Here's the response from the localization team:

The English src string is “Enable acrylic”. The suggestion is adding additional term “transparency”. We should not customize translation deviating from the source strings if not absolutely necessary. Would your team’s copy writer consider updating the source string to be something like “Enable acrylic transparency” or “Enable acrylic texture” (based on the dev comment)?

@lhecker lhecker added the Needs-Discussion Something that requires a team discussion before we can proceed label Feb 9, 2022
@zadjii-msft
Copy link
Member

Discussion: we thought "Enable acrylic transparency" was a fine string for now.

@zadjii-msft zadjii-msft removed the Needs-Discussion Something that requires a team discussion before we can proceed label Feb 14, 2022
@lhecker
Copy link
Member

lhecker commented Feb 16, 2022

I was about to change it to "acrylic transparency" but then I realized I should check what Microsoft uses officially...
Turns out "acrylic material" or "アクリル素材" is the proper name:

@lhecker lhecker mentioned this issue Feb 16, 2022
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Feb 16, 2022
@ghost ghost closed this as completed in #12505 Feb 18, 2022
ghost pushed a commit that referenced this issue Feb 18, 2022
@lhecker
Replace "acrylic" with "acrylic material" in i18n strings (#12505)
961c576 
"Acrylic material" is the official name as used on Microsoft Docs
and should ensure it gets properly translated in all languages.

## PR Checklist
* [x] Closes #9846
* [x] Closes MSFT:36776499
* [x] I work here

## Detailed Description of the Pull Request / Additional comments
We originally intended to replace the strings with "acrylic transparency",
but "acrylic material" is actually the official term on Microsoft Docs.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 18, 2022
carlos-zamora pushed a commit that referenced this issue May 12, 2022
@lhecker @carlos-zamora
Replace "acrylic" with "acrylic material" in i18n strings (#12505)
a38ca12 
"Acrylic material" is the official name as used on Microsoft Docs
and should ensure it gets properly translated in all languages.

## PR Checklist
* [x] Closes #9846
* [x] Closes MSFT:36776499
* [x] I work here

## Detailed Description of the Pull Request / Additional comments
We originally intended to replace the strings with "acrylic transparency",
but "acrylic material" is actually the official term on Microsoft Docs.

(cherry picked from commit 961c576)
Service-Card-Id: 81744865
Service-Version: 1.13
@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #12505, which has now been successfully released as Windows Terminal v1.13.1143.:tada:

Handy links:

@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #12505, which has now been successfully released as Windows Terminal Preview v1.14.143.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Localization Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
22H2
Development

Successfully merging a pull request may close this issue.

Replace "acrylic" with "acrylic material" in i18n strings microsoft/terminal
4 participants
@lhecker @skyline75489 @noriokaki @zadjii-msft