Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Tab does not Display the Background Image #9761

Closed
dougheeren opened this issue Apr 9, 2021 · 1 comment · Fixed by #9764
Closed

New Tab does not Display the Background Image #9761

dougheeren opened this issue Apr 9, 2021 · 1 comment · Fixed by #9764
Assignees
@PankajBhojwani
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.8

Comments

@dougheeren
Copy link

dougheeren commented Apr 9, 2021 •
edited
Loading

Windows Terminal version (or Windows build number)

Windows Build: 10.0.19042.906, Windows Terminal commit b310b1c built using Visual Studio 2019 16.9.3

Other Software

oh-my-posh 3.133.1
posh-git 1.0.0 (Latest)
PSReadLine 2.1.0

Ubuntu WSL 20.04

Steps to reproduce

Build Windows Terminal using visual studio. Release, x64, CascadiaPackage

  1. Configure a profile to use a background.
    image

  2. Exit Terminal

  3. Run Terminal and the background will be solid gray and not the image selected in step 1
    image

  4. Open Settings

  5. Save Settings

  6. The open tab background will show the background specified in settings
    image

  7. Start a new tab, and the background will be solid gray
    image

The kind of shell doesn't seem to affect this. I've tried Powershell 7.1.3, Ubuntu 20.04, git bash using MINGW64.

Expected Behavior

Opening a new Windows Terminal tab shows the background image specified in the profile.

Actual Behavior

Opening a new Windows Terminal tab does not show the background image specified in the profile.

Included Settings.json

settings.zip
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 9, 2021
@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Apr 9, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 9, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 9, 2021
@DHowett DHowett added this to the Terminal v1.8 milestone Apr 9, 2021
@PankajBhojwani PankajBhojwani mentioned this issue Apr 9, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 9, 2021
@dougheeren
Copy link
Author

Merging dev/pabhoj/defaults_fix fixed this issue.

@ghost ghost closed this as completed in #9764 Apr 12, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 12, 2021
ghost pushed a commit that referenced this issue Apr 12, 2021
@PankajBhojwani
Fix for some profiles.defaults settings not working (#9764)
7df4b3c 
Fix for profiles.defaults.colorScheme not working 
Fix for background image only showing up after a settings reload

Closes #9761
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.8
Development

Successfully merging a pull request may close this issue.

Fix for some profiles.defaults settings not working microsoft/terminal
3 participants
@DHowett @dougheeren @PankajBhojwani