Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BASH] Window Rename TeachingTip does not handle mixed system + terminal theme #9717

Closed
DHowett opened this issue Apr 6, 2021 · 2 comments · Fixed by #9732
Closed

[BASH] Window Rename TeachingTip does not handle mixed system + terminal theme #9717

DHowett opened this issue Apr 6, 2021 · 2 comments · Fixed by #9732
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@DHowett
Copy link
Member

DHowett commented Apr 6, 2021

It's another problem with the app theme being a sack of lies.

originated in 4/2 bug bash
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 6, 2021
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Priority-3 A description (P3) labels Apr 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 6, 2021
@zadjii-msft
Copy link
Member

img

@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 6, 2021
@zadjii-msft
Copy link
Member

Oh my god:
image

Just naively setting RequestedTheme on the TeachingTip is not good enough. Apparently that doesn't cascade down to contents of the TeachingTip??

@zadjii-msft zadjii-msft mentioned this issue Apr 6, 2021
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 6, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 6, 2021
@ghost ghost closed this as completed in #9732 Apr 7, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 7, 2021
ghost pushed a commit that referenced this issue Apr 7, 2021
@zadjii-msft
Match the RequestedTheme of our TeachingTips to the set theme (#9732)
361877c 
## Summary of the Pull Request

Make sure that the window renamer and other toasts follow the requested app theme. We accomplish this by doing something similar to what we do with ContentDialogs. Since TeachingTips aren't in the same XAML root, we have to traverse the entire tree upwards setting RequestedTheme. If we don't, then we'll update the background color of the TeachingTip, but not the text inside it. 

## References
* Added in #9662 and #9523 

## PR Checklist
* [x] Closes #9717
* [x] I work here
* [n/a] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed
Tested with system theme light & dark, and `theme` set to `light, dark, and unset, and verified that they worked as expected.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Match the RequestedTheme of our TeachingTips to the set theme microsoft/terminal
2 participants
@DHowett @zadjii-msft