Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DefApp] Complete Terminal-side UI chooser of registered defapp #9463

Closed
1 task done
miniksa opened this issue Mar 12, 2021 · 2 comments · Fixed by #9907
Closed
1 task done

[DefApp] Complete Terminal-side UI chooser of registered defapp #9463

miniksa opened this issue Mar 12, 2021 · 2 comments · Fixed by #9907
Labels
Area-DefApp Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@miniksa
Copy link
Member

miniksa commented Mar 12, 2021

TODO:

  • - Disable UI elements from Terminal sheet and write TODO item

Originally posted by @miniksa in #7489 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 12, 2021
@miniksa miniksa mentioned this issue Mar 12, 2021
Merged
7 tasks
@zadjii-msft zadjii-msft added Area-DefApp Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Mar 12, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 12, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Mar 12, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 13, 2021
@cinnamon-msft cinnamon-msft mentioned this issue Mar 31, 2021
Merged
@miniksa miniksa mentioned this issue Apr 20, 2021
Merged
7 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 20, 2021
@ghost ghost closed this as completed in #9907 Apr 28, 2021
ghost pushed a commit that referenced this issue Apr 28, 2021
@miniksa
Implement UI for choosing default terminal inside Settings page (#9907)
b7fa328 
Implement dropdown menu for choosing a default terminal application from inside the Windows Terminal Settings UI

## PR Checklist
* [x] Closes #9463 
* [x] I work here.
* [x] Manual tests passed
* [x] MicrosoftDocs/terminal#314 (and cross reference #9462)

## Detailed Description of the Pull Request / Additional comments
- Adds dropdown menu and a template card for displaying the available default applications (using the same lookup code as the console property sheet `console.dll`)
- Adds model to TSM for adapting the data for display and binding on XAML
- Lookup occurs on every page reload. Persistence only happens on Save Changes.
- Manifest changed for Terminal to add capability to opt-out of registry redirection so we can edit this setting

## Validation Steps Performed
- [x] Flipped the menu and pressed Save Changes and launched cmd from run box... it moved between the two.
- [x] Flipped system theme from light to dark and ensured secondary color looked good
- [x] Flipped the status with a different mechanism (conhost propsheet) and then reopened settings page and confirmed it loaded the updated status
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 28, 2021
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9907, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #9907, which has now been successfully released as Windows Terminal v1.11.2921.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-DefApp Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Implement UI for choosing default terminal inside Settings page microsoft/terminal
3 participants
@DHowett @miniksa @zadjii-msft