Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving the settings.json file creates a shadow on the tab? #8948

Closed
zadjii-msft opened this issue Jan 29, 2021 · 2 comments · Fixed by #11240
Closed

Saving the settings.json file creates a shadow on the tab? #8948

zadjii-msft opened this issue Jan 29, 2021 · 2 comments · Fixed by #11240
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

hey so I'm getting something like this. every time i save the settings.json with wt in the background the tab changes to this:

image
which is a similar look

Originally posted by @LuanVSO in #7532 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 29, 2021
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jan 29, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 29, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.7 milestone Jan 29, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 4, 2021
@zadjii-msft zadjii-msft mentioned this issue Feb 25, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Mar 1, 2021
Closed
@zadjii-msft
Copy link
Member Author

Environment

Windows build number: 10.0.19042.0
Windows Terminal version (if applicable): 1.6.10571.0

Any other software?

Steps to reproduce

Select a color for the the current terminal tab or create a new pane in a tab that already has a color selected.

Expected behavior

The color I selected would be the tab color.

Actual behavior

The tab shows as the faded version of the color that an unselected tab would have, but when I mouse over, or do some other action like switching panes, the right color does appear.

windows_terminal_color_faded

@zadjii-msft zadjii-msft mentioned this issue Mar 23, 2021
Closed
This was referenced Apr 26, 2021
Closed
Closed
@zadjii-msft zadjii-msft mentioned this issue Jun 1, 2021
Closed
This was referenced Sep 13, 2021
Closed
Merged
@ghost ghost added the In-PR This issue has a related PR label Sep 15, 2021
@ghost ghost closed this as completed in #11240 Sep 20, 2021
ghost pushed a commit that referenced this issue Sep 20, 2021
@zadjii-msft
Update to MUX 2.7 (#11240)
cfe14e8 
* this is the same thing as #10996, but with the fix that caused us to #11031  
* This includes microsoft/microsoft-ui-xaml#3769, so we had to make some adjustments to how we handle tab colors. It works the same as before.
* Should enable #11231 to be started
* [x] Closes #10508
* [x] Closes #7133
* [x] Closes #8948
* [ ] I need to finish letting my 19H1 VM boot to make sure unpackaged still works
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 20, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11240, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Update to MUX 2.7 microsoft/terminal
2 participants
@DHowett @zadjii-msft