Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize localization changes for Settings UI #8746

Closed
38 of 39 tasks
carlos-zamora opened this issue Jan 12, 2021 · 0 comments · Fixed by #8777
Closed
38 of 39 tasks

Finalize localization changes for Settings UI #8746

carlos-zamora opened this issue Jan 12, 2021 · 0 comments · Fixed by #8777
Assignees
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Jan 12, 2021

These are some text-related changes that need to happen in the Settings UI. We need to update all of these strings in the resw file soon so that there's enough time to localize them properly.

Setting text changes

  • Bell style "Visual (Flash Taskbar)" should be "Visual (flash taskbar)"
    • Consideration: only flashes if not focused
  • "Copy after selection is made" -> "Automatically copy selection to clipboard"
  • Theme radio buttons: Dark, Light, Use Windows theme
  • Hide the title bar (requires restart) -> Hide the title bar (requires relaunch)
  • Change Apply to Save
  • Show terminal title in title bar -> Use active terminal title as application title
  • Disable visual animations -> Disable pane animations
  • Antialiasing text -> Text antialiasing (requires relaunch)
  • How the profile closes -> Profile termination behavior: Always close, Close when exit is typed/process exits normally, Never close

Tooltip changes

  • Default profile tooltip: "Profile that opens when clicking the '+' icon or by typing the new tab key binding."
  • Launch mode tooltip: "How the terminal will appear on launch. Focus will hide the tabs and title bar."
  • Remove copyOnSelect ("Automatically copy selection to clipboard") tooltip from Interaction page
  • Word delimiters tooltip: "Symbols used to define boundaries between words."
  • Snap window resizing to character grid tooltip: "When unchecked, the window will resize smoothly."
  • Save button tooltip: "Save all unsaved settings."
  • Discard changes tooltip: "Discard all unsaved settings."
  • Antialiasing text tooltip informs user that the change requires a terminal restart, but for the 'hide the title bar' setting we inform the user about a restart being required in the setting itself (not a tooltip)
  • Theme tooltip: "Sets the theme of the application."
  • Hide the title bar tooltip: "When unchecked, the title bar will appear above the tabs."
  • Use active terminal title as application title tooltip: When unchecked, the application title will be 'Windows Terminal'."
  • Always show tabs tooltip: "When unchecked, the tab bar will appear when a new tab is created."
  • Tab width mode: "Compact will shrink unfocused tabs to the size of the icon."
  • Remove disable pane animations tooltip from Appearance page
  • Move color names into tooltips on the color schemes page
  • Remove delete color scheme button tooltip from Color schemes page
  • Redraw entire screen when display updates tooltip: "When unchecked, the terminal will render only the updates to the screen between frames."
  • Starting directory tooltip: "The directory the profile starts in when it is loaded."
  • Icon tooltip: "Emoji or image file location of the icon used in the profile."
  • Tab title tooltip: "Replaces the profile name as the title to pass to the shell on startup."
  • Padding tooltip: "Sets the padding around the text within the window."
  • Remove scrollbar visibility tooltip.
  • Remove cursor shape tooltip.
  • Background image tooltip: "File location of the image used in the background of the window."
  • Enable acrylic tooltip: "Applies a translucent texture to the background of the window."
  • Acrylic opacity tooltip: "Sets the transparency of the window."
  • Suppress title changes tooltip: "Use the tab title to override the default title of the tab and suppress any title change messages from the application."
  • Text antialiasing tooltip: "Controls how text is antialiased in the renderer."
  • Remove scroll to input when typing tooltip.
  • Remove how the profile closes tooltip.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Area-Settings UI Anything specific to the SUI labels Jan 12, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.6 milestone Jan 12, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@cinnamon-msft cinnamon-msft self-assigned this Jan 12, 2021
@ghost ghost added the In-PR This issue has a related PR label Jan 13, 2021
@ghost ghost closed this as completed in #8777 Jan 19, 2021
ghost pushed a commit that referenced this issue Jan 19, 2021
Change wording for some settings and tooltips to make them clearer.

Closes #8746
mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
Change wording for some settings and tooltips to make them clearer.

Closes microsoft#8746
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants