Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing when using tabSearch triggered via shortcut Ctrl + N #8612

Closed
qwertynik opened this issue Dec 18, 2020 · 10 comments
Closed

Crashing when using tabSearch triggered via shortcut Ctrl + N #8612

qwertynik opened this issue Dec 18, 2020 · 10 comments
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@qwertynik
Copy link

qwertynik commented Dec 18, 2020

Environment

Windows build number: 
Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19041.0 Microsoft Windows NT 10.0.19041.0

Windows Terminal version (if applicable):
Version: 1.4.3243.0

Steps to reproduce

When triggering the tabSearch using a shortuct Ctrl + N the terminal crashes. Not always though.

Expected behavior

Tab search popup should open

Actual behavior

Sometimes instead of the tab search popup opening, the Terminal crashes.

Additional Info

More often than not, whenever the terminal crashed, I had 4 tabs with SSH connections and one with Powershell. VPN turned on. So a total of 5 tabs. To me, this looks like a coincidence.
PS: This information might not help in root-causing the bug. But adding it anyway, just in case it helps!

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 18, 2020
@qwertynik qwertynik changed the title Crashing when using tabSearch triggered via shortcut Ctrl + N Crashing when using tabSearch triggered via shortcut Ctrl + N Dec 18, 2020
@qwertynik
Copy link
Author

Would be willing to upload any log data if required. Adding steps on how to do so would be essential and helpful.

Thanks!

@skyline75489
Copy link
Collaborator

Is there any other software running in the background?

@qwertynik
Copy link
Author

qwertynik commented Dec 18, 2020

@skyline75489
In the background via the terminal? If you are speaking about other apps running on windows, here are they:

  • PHPStorm
  • Chrome
  • Firefox
  • Airtable
  • Google Chat App
  • jMeter
  • XAMPP. For PHP, Apache and MariaDB

Let me know if there is anything else that would help with root-causing the bug.

@skyline75489
Copy link
Collaborator

Recently we received report about clipboardmaster causing crashes. Back then PowerToys can also cause malfunction in the terminal. So yeah something like that, which might interferer keyboard, interaction, etc.

@qwertynik
Copy link
Author

qwertynik commented Dec 18, 2020

@skyline75489
No such tool is currently being used the only exception being the new Clipboard tool that comes pre-installed with Windows. Opened using StartKey+V. That allows me to paste items that were copied much earlier.
If there are any crash logs that could be shared securely that can be done.

@skyline75489
Copy link
Collaborator

Well the bot does not like me, but yeah. Normally people could use feedback hub like this #8287 (comment)

@zadjii-msft
Copy link
Member

Yea, I'd follow the steps in that thread, including in this link

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 18, 2020
@qwertynik
Copy link
Author

@skyline75489 @zadjii-msft
Thanks for sharing the steps. Here is the feedback.
Hopefully, this is resolved at the earliest.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 19, 2020
@qwertynik
Copy link
Author

@skyline75489 @zadjii-msft

Do let me know if any additional information is required in resolving this issue and making the Terminal app even better.

@DHowett
Copy link
Member

DHowett commented Jan 28, 2021

Thanks again for the report, and the feedback hub link! I just gave it a shot a lot in the 1.6 preview, and I believe that one of @Don-Vito's many command palette changes fixed it. I can't be sure, of course, but so much code changed in that area that it's going to be hard to correlate.

Please reopen this in a couple days if the 1.5 and 1.6 updates have the same problem.

@DHowett DHowett closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants