Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal crashing when resizing panes #8287

Closed
wolffberg opened this issue Nov 16, 2020 · 10 comments
Closed

Windows Terminal crashing when resizing panes #8287

wolffberg opened this issue Nov 16, 2020 · 10 comments
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Severity-Crash Crashes are real bad news.

Comments

@wolffberg
Copy link

Environment

Windows build number....: 10.0.19041.0 (issue also seen on earlier versions)
Windows Terminal version: 1.4.3141.0
Pwsh version............: 7.1.0        (issue also seen on earlier versions)

Steps to reproduce

  • Open Windows Terminal
  • Maximize window to have more space for resizing (optional but makes it easier to reproduce)
  • Split the terminal horizontally and then vertically into panes
  • Resize bottom two panes up and down repeatedly using keyboard shortcuts

Expected behavior

The panes should resize without issues

Actual behavior

Windows Terminal crashes

Notes

  • The crash can happen at any given time while resizing panes. Some times you will be able to resize a lot, some times the crash happens instantly.
  • The issue have been observed on multiple different devices.
  • The issue is tested with pwsh, wsl and cmd running in the panes.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 16, 2020
@wolffberg wolffberg changed the title Windows Terminal crashing while resizing panes Windows Terminal crashing when resizing panes Nov 16, 2020
@DHowett
Copy link
Member

DHowett commented Nov 20, 2020

That's almost certainly not right. Would you mind filling out a feedback item to see if we can get some crash logs?

If that doesn't work, I'll write up tracing steps. 😄

@DHowett
Copy link
Member

DHowett commented Nov 20, 2020

/feedback

@ghost
Copy link

ghost commented Nov 20, 2020

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 20, 2020
@wolffberg
Copy link
Author

Sure thing https://aka.ms/AAae833 🤞

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 23, 2020
@webnoob
Copy link

webnoob commented Nov 24, 2020

I too have a similar issue. I have a powershell script which loads scripts into 2 tabs with 1 pane on one tab and 5 panes on the other. When it's loading, if I grab the bottom right corner of the terminal and drag it quickly to resize, it closes the terminal.

This is the command I use (specific to my project but the general idea should help):

wt `; new-tab -p "DevTestingApi" powershell.exe -command "yarn start:testing" `; new-tab -p "DevApi" powershell.exe -command "yarn start:dev" `; split-pane -p "DevApp" powershell.exe -command "yarn dev" `; split-pane -p "DevCommon" powershell.exe -command "yarn dev" `; split-pane -p "DevApp" powershell.exe -command "yarn test:e2e" `; split-pane -p "DevApp" powershell.exe -command "yarn test:unit:ui"

@DHowett
Copy link
Member

DHowett commented Nov 25, 2020

Alright, this is gonna seem like I'm giving you the runaround. Sorry for that.

On Monday, I set up better tracing for our feedback hub entry! Unfortunately, it requires a "repro mode" feedback hub capture.

Would you mind filing another feedback hub item? It'll help us capture those new traces.
Please make sure you do the following:

  1. Use the Apps, "Windows Terminal" category. There shouldn't be a "(Preview)" version any more.
    • This is what enables the terminal-specific tracing
  2. Use "start recording" .. you can choose "include data about ... general". image
  3. Crash Terminal while it's recording!
  4. Stop recording, submit, share link like before.

Thanks again 😄

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 25, 2020
@wolffberg
Copy link
Author

There you go https://aka.ms/AAaetoj

Yesterday I tried replicating the issue on a fresh Windows 10 installation and weren't able to reproduce. I only added my keybindings to settings.json but didn't install any fonts. I usually use https://github.com/powerline/fonts 🤔

        {
            "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
            "hidden": false,
            "name": "PowerShell Core",
            "source": "Windows.Terminal.PowershellCore",
            "fontFace": "Meslo LG S DZ for Powerline",
            "fontSize": 10
        },

@zadjii-msft
Copy link
Member

Oh no, with the holidays at the end of the year, it looks like this one got lost. Now that it's been more than 60 days, the feedback got flushed from the backend ☹️

Would you mind submitting it again? I'm fairly confident that this is the same issue as #4907, but it'll be good to know for sure.

Sorry about that!

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Severity-Crash Crashes are real bad news. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 26, 2021
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Mar 30, 2021
@ghost
Copy link

ghost commented Mar 30, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Apr 2, 2021
@VanVan
Copy link

VanVan commented Oct 19, 2022

I have the same problem, I will open a new thread

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Oct 19, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

5 participants