Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The index param of closeOtherTabs, closeTabsAfter should be optional #7181

Closed
zadjii-msft opened this issue Aug 4, 2020 · 0 comments · Fixed by #7390
Closed

The index param of closeOtherTabs, closeTabsAfter should be optional #7181

zadjii-msft opened this issue Aug 4, 2020 · 0 comments · Fixed by #7390
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@zadjii-msft
Copy link
Member

Similar to how closeTab defaults to "the active tab" when no index is provided.

This is being tracked with the other support for customizing the new-tab dropdown, which will need the ability to specify and action for the "close tab" menu item

This is also related to #7176 and #7180
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 4, 2020
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 4, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 4, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 4, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 6, 2020
@zadjii-msft zadjii-msft mentioned this issue Aug 25, 2020
Closed
@carlos-zamora carlos-zamora mentioned this issue Aug 25, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 25, 2020
@ghost ghost closed this as completed in #7390 Aug 25, 2020
ghost pushed a commit that referenced this issue Aug 25, 2020
@carlos-zamora
Make index in closeOtherTabs and closeTabsAfter optional (#7390)
2fdc88f 
## Summary of the Pull Request
The `index` action argument is now optional for `closeOtherTabs` and `closeTabsAfter`. When `index` is not defined, `index` is set to the focused tab's index.

Also, adds the non-index version of these actions to defaults.json.

## PR Checklist
* [X] Closes #7181 
* [X] CLA signed
* [X] Tests passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [X] Schema updated.

## Validation Steps Performed
Opened 4 tabs and ran closeOtherTabs/closeTabsAfter from command palette.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 25, 2020
DHowett pushed a commit that referenced this issue Aug 25, 2020
@carlos-zamora @DHowett
Make index in closeOtherTabs and closeTabsAfter optional (#7390)
88e843d 
## Summary of the Pull Request
The `index` action argument is now optional for `closeOtherTabs` and `closeTabsAfter`. When `index` is not defined, `index` is set to the focused tab's index.

Also, adds the non-index version of these actions to defaults.json.

## PR Checklist
* [X] Closes #7181
* [X] CLA signed
* [X] Tests passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [X] Schema updated.

## Validation Steps Performed
Opened 4 tabs and ran closeOtherTabs/closeTabsAfter from command palette.

(cherry picked from commit 2fdc88f)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Make index in closeOtherTabs and closeTabsAfter optional microsoft/terminal
2 participants
@DHowett @zadjii-msft