Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Match the Terminal frame and Tab color scheme to Edge #7005

Closed
bonzibudd opened this issue Jul 22, 2020 · 1 comment
Closed
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.

Comments

@bonzibudd
Copy link

bonzibudd commented Jul 22, 2020

Description of the new feature/enhancement

-This enhancement would match the color scheme to the Chromium version of Edge, it would improve consistency between apps

-The app wouldn't be used differently, but it would look nicer and follow the fluent design language more closely. The current implementation has the tabs too dark and the background too light.

Complete description

-I would like the color scheme for the Tab bar and frame of Windows Terminal to match Microsoft Edge in the light and dark theme. Additionally, the bottom corners of the tabs should be curved like Edge, and not be at a solid 90 degree angle as it is right now.

@bonzibudd bonzibudd added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 22, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 22, 2020
@zadjii-msft
Copy link
Member

zadjii-msft commented Jul 22, 2020

This might be a neat idea for a default theme once #3327 lands, but I don't think we're about to change the default colors before that. I could imagine a default theme with

        {
            "name": "Edge",
            "window.applicationTheme": "system",
            "tab.background": "#whatever-color-edge-is",
            "tabRow.background": "accent",
        },

would get the same effect.

I've linked this up to the spec in review over at #5772, and I'm gonna close this out in favor of that feature. Thanks!

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Jul 22, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 22, 2020
zadjii-msft added a commit that referenced this issue Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants