Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context Menu Item for Find #5633

Closed
Chips1234 opened this issue Apr 29, 2020 · 9 comments · Fixed by #13055
Closed

Context Menu Item for Find #5633

Chips1234 opened this issue Apr 29, 2020 · 9 comments · Fixed by #13055
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@Chips1234
Copy link
Contributor

Chips1234 commented Apr 29, 2020 •
edited
Loading

Description of the new feature/enhancement

A menu flyout item for the find feature.
@Chips1234 Chips1234 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 29, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 29, 2020
@zadjii-msft
Copy link
Member

Thanks for the offer of help! I think we're trying pretty hard ad the moment to not add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this:
image

Hopefully once #3789 lands (in 1.1), then we'll be able to add menu entries to the right-click menu on a tab, and I think that's probably a better place to put something like this.

Then there's also #3337 for adding a context menu to the terminal controls themselves, which would also be an appropriate place for this

Then of course, there's always #5400, which is another possible place.

I'm going to leave this open as a potential follow-up task of either #3337 or #3789

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Apr 29, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 29, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Apr 29, 2020
@Chips1234
Copy link
Contributor Author

Alright, we'll talk about it when context menu is introduced.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 30, 2020
@Chips1234
Copy link
Contributor Author

Thanks for the offer of help! I think we're trying pretty hard ad the moment to not add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this:
image

Is that Microsoft saying that their own products are a mess? Lol

@DHowett-MSFT

This comment has been minimized.

Sign in to view
@Chips1234

This comment has been minimized.

Sign in to view
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 11, 2020
@DHowett-MSFT DHowett-MSFT reopened this May 11, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 11, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue May 11, 2020
Closed
@Chips1234 Chips1234 changed the title Menu Item for Find Context Menu Item for Find May 11, 2020
@zadjii-msft zadjii-msft mentioned this issue Jul 13, 2020
Closed
3 tasks
@zadjii-msft zadjii-msft mentioned this issue Aug 4, 2020
Merged
3 tasks
zadjii-msft added a commit that referenced this issue Aug 12, 2020
@zadjii-msft
Spec for global action IDs (#7175)
c241f83 
## Summary of the Pull Request

⚠️ This spec has been moved from #6902. That version was branched off the new tab menu customization, and had a terribly convoluted git history. After discussion with the team, we've decided that it's best that this spec is merged atomically _first_, and used as the basis for #5888, as opposed to the other way around.

> This document is intended to serve as an addition to the [Command Palette Spec],
> as well as the [New Tab Menu Customization Spec].
> 
> As we come to rely more on actions being a mechanism by which the user defines
> "do something in the Terminal", we'll want to make it even easier for users to
> re-use the actions that they've already defined, as to reduce duplicated json as
> much as possible. This spec proposes a mechanism by which actions could be
> uniquely identifiable, so that the user could refer to bindings in other
> contexts without needing to replicate an entire json blob.
> 

## PR Checklist
* [x] Specs: #6899
* [x] References: #1571, #1912, #3337, #5025, #5524, #5633
* [x] I work here

## Detailed Description of the Pull Request / Additional comments
_\*<sup>\*</sup><sub>\*</sub> read the spec  <sub>\*</sub><sup>\*</sup>\*_



[Command Palette Spec]: https://github.com/microsoft/terminal/blob/master/doc/specs/%232046%20-%20Command%20Palette.md
[New Tab Menu Customization Spec]: https://github.com/microsoft/terminal/blob/master/doc/specs/%231571%20-%20New%20Tab%20Menu%20Customization.md
@zadjii-msft zadjii-msft mentioned this issue Mar 4, 2021
Closed
8 tasks
@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. labels Mar 4, 2021
@DavidJRWang
Copy link

In regards to the above discussion, has it been determined whether or not this is something that is wanted?

@zadjii-msft
Copy link
Member

Honestly, I don't remember. I thought I closed this because eventually we were going to make it possible for users to add this on their own. I don't remember why I tagged this easy starter...

...

Okay, now I'm remembering. We thought it was a fine idea for someone to add to the tab context menu
image

And that should be relatively easy to do.

@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Jan 4, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jan 4, 2022
@Predelnik Predelnik mentioned this issue May 7, 2022
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label May 7, 2022
@ghost ghost closed this as completed in #13055 May 16, 2022
ghost pushed a commit that referenced this issue May 16, 2022
@Predelnik
Add find item to tab menu (#13055)
b851b0d 
## Summary of the Pull Request

Add `Find` to tab context menu as describe in issue #5633.

## PR Checklist
* [x] Closes #5633
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Detailed Description of the Pull Request / Additional comments

Just wanted to solve `Easy Starter` issue, so any corrections/suggestions welcome. There's a couple of points I'm not sure of
* Placement of item within menu, currently it's at the end before close tab block.
* Should it be named longer, something like `Find in Tab` of just `Find` is fine?
* The workaround for focus similar to tab rename is a bit annoying, especially because it required adding a method to `TermControl` but without it find window obviously opens without focus which is bad.

## Validation Steps Performed

Open menu, press menu item try to find things via opened find dialog.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 16, 2022
DHowett pushed a commit that referenced this issue Jun 30, 2022
@Predelnik @DHowett
Add find item to tab menu (#13055)
31757a4 
## Summary of the Pull Request

Add `Find` to tab context menu as describe in issue #5633.

## PR Checklist
* [x] Closes #5633
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Detailed Description of the Pull Request / Additional comments

Just wanted to solve `Easy Starter` issue, so any corrections/suggestions welcome. There's a couple of points I'm not sure of
* Placement of item within menu, currently it's at the end before close tab block.
* Should it be named longer, something like `Find in Tab` of just `Find` is fine?
* The workaround for focus similar to tab rename is a bit annoying, especially because it required adding a method to `TermControl` but without it find window obviously opens without focus which is bad.

## Validation Steps Performed

Open menu, press menu item try to find things via opened find dialog.

(cherry picked from commit b851b0d)
Service-Card-Id: 83524184
Service-Version: 1.14
@ghost
Copy link

ghost commented Jul 6, 2022

🎉This issue was addressed in #13055, which has now been successfully released as Windows Terminal v1.14.186.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 6, 2022

🎉This issue was addressed in #13055, which has now been successfully released as Windows Terminal Preview v1.15.186.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add find item to tab menu Predelnik/terminal
4 participants
@DHowett-MSFT @zadjii-msft @DavidJRWang @Chips1234