Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The split-pane subcommand has a --target\-t parameter #4878

Closed
wayne-scott opened this issue Mar 10, 2020 · 2 comments · Fixed by #4888
Closed

The split-pane subcommand has a --target\-t parameter #4878

wayne-scott opened this issue Mar 10, 2020 · 2 comments · Fixed by #4888
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@wayne-scott
Copy link

The split-pane section in the UsingCommandlineArguments document says that there is a [--target,-t target-pane] parameter. However if you try to use it you get a windows error box stating "The following argument was not expected: -t".

I've not looked into the code base in great detail, but from looking at this section I'm assuming that this parameter hasn't been implemented yet.
@wayne-scott wayne-scott added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Mar 10, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 10, 2020
@zadjii-msft
Copy link
Member

You're absolutely right that this hasn't been implemented yet. I copy-pasta'd that section from the spec, then forgot to remove that arg. 🤦‍♂

Thanks for catching this!

zadjii-msft added a commit that referenced this issue Mar 11, 2020
@zadjii-msft
Remove unimplemented -t arg from split-pane
18b873a 
Fixes #4878
@zadjii-msft zadjii-msft mentioned this issue Mar 11, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 11, 2020
DHowett-MSFT pushed a commit that referenced this issue Mar 11, 2020
@zadjii-msft
doc: remove unimplemented -t arg from split-pane (#4888)
ca8d101 
Fixes #4878
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 11, 2020
@wayne-scott
Copy link
Author

@zadjii-msft, just a quick followup question. I want to keep track of when this will be implemented but couldn't find an issue to follow. The best I could find was #4632, but it didn't mention this particular parameter. Can you point me in the right direction?

abhijeetviswam pushed a commit to abhijeetviswam/terminal that referenced this issue Mar 12, 2020
@zadjii-msft @abhijeetviswam
doc: remove unimplemented -t arg from split-pane (microsoft#4888)
6984df6 
Fixes microsoft#4878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: remove unimplemented -t arg from split-pane microsoft/terminal
2 participants
@wayne-scott @zadjii-msft