Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase padding around tabs #3370

Closed
cinnamon-msft opened this issue Oct 29, 2019 · 7 comments · Fixed by #3513
Closed

Increase padding around tabs #3370

cinnamon-msft opened this issue Oct 29, 2019 · 7 comments · Fixed by #3513
Assignees
@cinnamon-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1911

Comments

@cinnamon-msft
Copy link
Contributor

Description of the new feature/enhancement

Increase the left and top padding around the tabs to match our original mockup:

Terminal Mockup

Current version (v0.6):

Terminal v0.6

Proposed technical implementation details (optional)
@cinnamon-msft cinnamon-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Oct 29, 2019
@cinnamon-msft cinnamon-msft added this to the Terminal-1911 milestone Oct 29, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 29, 2019
@DHowett-MSFT
Copy link
Contributor

Remember: any padding around the tabs is not usable to drag or resize the window.

@mdtauk
Copy link

mdtauk commented Oct 29, 2019

With the larger padding space, perhaps you could round the corners of the Terminal area, so it blends better

@zadjii-msft
Copy link
Member

I concur with @mdtauk, I want the little bottom rounded corners too :)

Also, do we intent on adding the shadow to the tabs as well? I presumed that would have been included by MUX by default, but that does not seem to be the case...

@cinnamon-msft
Copy link
Contributor Author

I believe shadows are included in the next preview version of the tabView. I was going to make a new issue for that. 😄

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 29, 2019
@electronic-dk
Copy link

A bit of an offtop: is this bottom bar on the mock up (which btw looks awesome) scheduled for Terminal 1.0? I can't seem to find a github ticket for it.

@zadjii-msft
Copy link
Member

@electronic-dk Apparently there never was a thread for it, so I made #3459 just now. It's not in scope for 1.0 unfortunately. I'll direct further discussion on the subject to that thread.

@cinnamon-msft cinnamon-msft mentioned this issue Nov 11, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Nov 11, 2019
@cinnamon-msft cinnamon-msft self-assigned this Nov 11, 2019
DHowett-MSFT pushed a commit that referenced this issue Nov 12, 2019
@cinnamon-msft @DHowett
Increase left padding around tabs (#3513)
d2ca3c1 
Closes #3370.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 12, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

🎉This issue was addressed in #3513, which has now been successfully released as Windows Terminal Preview v0.7.3291.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cinnamon-msft cinnamon-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal-1911
Development

Successfully merging a pull request may close this issue.

Increase left padding around tabs microsoft/terminal
5 participants
@electronic-dk @mdtauk @DHowett-MSFT @zadjii-msft @cinnamon-msft