Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical resizing doesn't redraw properly #3207

Closed
cinnamon-msft opened this issue Oct 15, 2019 · 0 comments · Fixed by #3214
Closed

Vertical resizing doesn't redraw properly #3207

cinnamon-msft opened this issue Oct 15, 2019 · 0 comments · Fixed by #3214
Assignees
@DHowett-MSFT
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1910

Comments

@cinnamon-msft
Copy link
Contributor

Environment

Windows build number: 10.0.18990.0
Windows Terminal version (if applicable): After 1909 release, built from master, latest commit: https://github.com/microsoft/terminal/commit/df26c677efcb815a3b66a974345c9d3483cab678

Any other software?

Steps to reproduce

Resize the Terminal from the bottom or double click to make it full screen. Any vertical resizing will do it.

Expected behavior

Everything draws properly and the background color fills the window.

Actual behavior

The background doesn't fill and black rectangles fill it instead. Improper redrawing.

verticalredrawbug
@cinnamon-msft cinnamon-msft added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Oct 15, 2019
@cinnamon-msft cinnamon-msft added this to the Terminal-1910 milestone Oct 15, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 15, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 15, 2019
DHowett-MSFT pushed a commit that referenced this issue Oct 15, 2019
@DHowett
Make sure we resize the region even when the drag bar didn't change
659502e 
Fixes #3207.
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 15, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 15, 2019
@egmontkob egmontkob mentioned this issue Oct 16, 2019
Closed
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 17, 2019
miniksa pushed a commit that referenced this issue Oct 17, 2019
@DHowett @miniksa
Make sure we resize the region even when the drag bar didn't ch… (#3214)
d80500f 
Fixes #3207.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal-1910
Development

Successfully merging a pull request may close this issue.

Make sure we resize the region even when the drag bar didn't change microsoft/terminal
2 participants
@DHowett-MSFT @cinnamon-msft