Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new window key binding #2068

Closed
havidarou opened this issue Jul 23, 2019 · 4 comments
Closed

Create new window key binding #2068

havidarou opened this issue Jul 23, 2019 · 4 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@havidarou
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.239]
Windows Terminal version (if applicable): 0.2.1831.0

Steps to reproduce

I edit my settings to add a key binding for newWindow as listed here: https://github.com/microsoft/terminal/blob/v0.2.1831.0/src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp#L28

This is a sample of the configuration:

            {
                "command" : "newWindow",
                "keys" : 
                [
                    "ctrl+n"
                ]
            }

Expected behavior

Upon pressing ctrl+n a new Windows terminal window should be opened.

Actual behavior

Nothing happens.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 23, 2019
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 25, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 25, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 25, 2019
@zadjii-msft
Copy link
Member

Yea, that one hasn't been implemented yet. We should do that.

@DHowett-MSFT DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 29, 2019
@zadjii-msft zadjii-msft mentioned this issue Nov 8, 2019
Merged
3 tasks
zadjii-msft added a commit that referenced this issue Jan 15, 2020
@zadjii-msft @DHowett
Add spec for adding commandline arguments to wt.exe (#3495)
1f7578f 
## Summary of the Pull Request

This is the spec for adding commandline arguments to the Windows Terminal. This includes design work for a powerful future version of the commandline args for the Terminal, as well as a way that system could be implemented during 1.0 to provide basic functionality, while creating commandlines that will work without modification in (a future Windows Terminal version).   

## References

Referenced in the course of this spec:

* #607  Feature Request: wt.exe supports command line arguments (profile, command, directory, etc.) 
* #1060 Add "open Windows terminal here" into right-click context menu 
* #576  Feature Request: Task Bar jumplist should show items from profile 
* #1357 Draft spec for adding profiles to the Windows jumplist 
* #2080 Spec for tab tear off and default app 
* #632  [Question] Configuring Windows Terminal profile to always launch elevated 
* #2068 New window key binding not working 

## PR Checklist
* [x] Specs #607
* [x] I work here
* [x] _it's a spec_

## Detailed Description of the Pull Request / Additional comments

Read the spec.

-----------------------------------------------------
* Let's commit this bewfore I go hog-wild on new-window

* new-window vs new-tab discussion

* Well, this is ready for a review

* -P -> -% for --percent

* Big note on powershell

  of course, powershell has to use `;` as the command seperator

* Minor typos

* This is a lot of feedback from PR

  bigly, it's focus-pane and focus-tab

* Add notes on implementation, based on investigation

* Apply suggestions from @miniksa

* some updates after actually implementing the thing

* some minor things from PR

* Apply suggestions from code review

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>

* comments from dustin's latest review

* more comments from dustin

* mostly just typos

Co-authored-by: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
@cinnamon-msft cinnamon-msft changed the title New window key binding not working Create new window key binding Jan 23, 2020
@ffes
Copy link

ffes commented Mar 4, 2020

Isn't this a dup of #1051 (which is placed on Terminal Backlog BTW)

@zadjii-msft
Copy link
Member

🤦‍♂ yep it definitely is, thanks for helping clear up our backlog ☺️

/dup #1051

@ghost
Copy link

ghost commented Mar 4, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 4, 2020
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Mar 4, 2020
@zadjii-msft zadjii-msft removed this from the Terminal v1.x milestone Mar 4, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ffes @havidarou @DHowett-MSFT @zadjii-msft @cinnamon-msft