Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for more VT sequences and special characters #1883

Closed
Tracked by #10001
PankajBhojwani opened this issue Jul 8, 2019 · 5 comments
Closed
Tracked by #10001

Implement support for more VT sequences and special characters #1883

PankajBhojwani opened this issue Jul 8, 2019 · 5 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@PankajBhojwani
Copy link
Contributor

Summary of the new feature/enhancement

We need to support more VT sequences and special characters so that when we establish non-Conhost connections those sequences/characters are dealt with. VT sequences such as erase-in-line and special characters such as BEL should be implemented.

Proposed technical implementation details (optional)

VT sequences need to be implemented in TerminalDispatch.hpp/cpp and special characters need to be implemented in Terminal.cpp - in the _WriteBuffer function (these files are in TerminalCore). For reference for how these functions could be implemented, see adaptDispatch.cpp (in TerminalAdapter).
@PankajBhojwani PankajBhojwani added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 8, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 8, 2019
@PankajBhojwani PankajBhojwani added Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Area-Input Related to input processing (key presses, mouse, etc.) Area-VT Virtual Terminal sequence support and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jul 8, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 8, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 8, 2019
@oising
Copy link
Collaborator

oising commented Jul 10, 2019

I'm building out a specification that we will be using to track VT sequence support. See #1884

@zadjii-msft zadjii-msft mentioned this issue Jul 11, 2019
Merged
10 tasks
@PankajBhojwani PankajBhojwani mentioned this issue Jul 29, 2019
Merged
1 task
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Jul 29, 2019
@bitcrazed bitcrazed mentioned this issue Sep 9, 2019
Closed
@j4james j4james mentioned this issue Sep 28, 2019
Closed
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Dec 19, 2019
@skyline75489 skyline75489 mentioned this issue Mar 24, 2021
Merged
3 tasks
ghost pushed a commit that referenced this issue Apr 16, 2021
@skyline75489
Initial Implementation for tab stops in TerminalDispatch (#9597)
b68ee23 
* [x] Supports #1883
* [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [X] Tests added/passed
mpela81 pushed a commit to mpela81/terminal that referenced this issue Apr 17, 2021
@skyline75489 @mpela81
Initial Implementation for tab stops in TerminalDispatch (microsoft#9597
5095120 
)

* [x] Supports microsoft#1883
* [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [X] Tests added/passed
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Jan 18, 2022
Open
16 tasks
@zadjii-msft
Copy link
Member

See also: #13408

@zadjii-msft zadjii-msft added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Jul 2, 2024
@zadjii-msft
Copy link
Member

Tagging for discussion/triage to see if we can de-dupe this with #13408 these days

@carlos-zamora
Copy link
Member

/dup #13408

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot removed this from the Backlog milestone Jul 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 3, 2024
@zadjii-msft zadjii-msft removed the Needs-Discussion Something that requires a team discussion before we can proceed label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@oising @carlos-zamora @DHowett-MSFT @zadjii-msft @PankajBhojwani