Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar and settings are shown at the same time #16906

Open
cz-lucas opened this issue Mar 20, 2024 · 7 comments · May be fixed by #17198
Open

Sidebar and settings are shown at the same time #16906

cz-lucas opened this issue Mar 20, 2024 · 7 comments · May be fixed by #17198
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.

Comments

@cz-lucas
Copy link

Windows Terminal version

1.19.10573.0

Windows build number

10.0.19045.3930

Other Software

No response

Steps to reproduce

  1. Open the windows-terminal with a width of around 500px
  2. Open the settings

Expected Behavior

image

Actual Behavior

There is no overlaying text over the settings and the sidebar is hidden.

@cz-lucas cz-lucas added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 20, 2024
@zadjii-msft
Copy link
Member

Huh, we saw this before in #9337 which should have been fixed in #9752, back in 1.8.

Though, it seems like those resources got lost some time ago: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsEditor/MainPage.xaml

Oh dear it was lost in #12973

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI labels Mar 20, 2024
@zadjii-msft zadjii-msft added this to the Terminal v1.21 milestone Mar 20, 2024
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 20, 2024
@marcelwgn
Copy link
Contributor

That's odd, I'm unable to reproduce this issue. Might this be a Win 10 issue maybe?

@AlejandroBlanco2001
Copy link
Contributor

AlejandroBlanco2001 commented Apr 2, 2024

Hey @marcelwgn @zadjii-msft , I was able to reproduce it on my W10 machine with the version of the terminal 1.19.10573.0. I followed the same steps as mentioned in the description.

image

If possible, I would like to investigate this issue a little bit more

@AlejandroBlanco2001
Copy link
Contributor

AlejandroBlanco2001 commented Apr 27, 2024

@marcelwgn, apologies for the delayed update. The concept suggested by @zadjii-msft in #9752 is the root cause of the issue addressed by the changes implemented in #9752. These changes enable the modification of the panel's color when it's not being rendered (using AcrylicBrush with the property FallbackColor). However, in change #12973, we altered this to utilize a solid transparent background instead. My inquiry is whether we should strive to replicate the same functionality with the subsequent implementation, or revert to the solution put forth in #9752. For simplicty, I would stick with the previous way, I'm happy to make the changes in a PR once the question is answered 😄
image

@zadjii-msft
Copy link
Member

I'd honestly just revert back to the acrylic brush with a fallback color set. This is so wacky when it does happen, that literally anything would be better than this 😅

@AlejandroBlanco2001
Copy link
Contributor

@zadjii-msft Sure, I will do that today, and I will submit the PR. Thanks for the feedback 😄

@AlejandroBlanco2001
Copy link
Contributor

AlejandroBlanco2001 commented May 6, 2024

@zadjii-msft @marcelwgn PR opened 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
Status: To Cherry Pick
Status: To Cherry Pick
Development

Successfully merging a pull request may close this issue.

4 participants