Font variant ignored by copyFormatting

[champignoom]

Windows Terminal version

1.17.11461.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

Add copyFormatting: "html" to config,
open a markdown document in neovim, type *asdf* **asdf** <u>asfd</u>

Then copy it to MS word.

Expected Behavior

Italic, bold and underline should be preserved.

Actual Behavior

The variants are ignored.

[zadjii-msft]

That probably makes sense. I think GenHTML predates our support for bold and italic. Good find!

Note

Walkthrough

Just about here is where we'd need to fix this:

terminal/src/buffer/out/textBuffer.cpp

Lines 2124 to 2141 in 1745857

	if (colorChanged)
	{
	writeAccumulatedChars(false);
	if (hasWrittenAnyText)
	{
	htmlBuilder << "</SPAN>";
	}
	htmlBuilder << "<SPAN STYLE=\"";
	htmlBuilder << "color:";
	htmlBuilder << Utils::ColorToHexString(fgColor.value());
	htmlBuilder << ";";
	htmlBuilder << "background-color:";
	htmlBuilder << Utils::ColorToHexString(bkColor.value());
	htmlBuilder << ";";
	htmlBuilder << "\">";
	}

That'll need to account for other TextAttributes too, beyond just color.

[tusharsnx]

We should really be using all useful TextAttributes during formatted copy. Do note that some clients (that receives) formatting information might ignore unsupported properties.

terminal/src/buffer/out/textBuffer.cpp

Lines 2015 to 2018 in 1745857

	std::string TextBuffer::GenHTML(const TextAndColor& rows,
	const int fontHeightPoints,
	const std::wstring_view fontFaceName,
	const COLORREF backgroundColor)

Instead of TextAndColor, we can send the current TextAttributes and properties can be read directly from it.

Italic, bold and underline should be preserved.

I tried this for underlines, and already has something that works. Two problems though:

• Couldn't find clients that would actually use those CSS underline properties (color/style). So, they're getting ignored anyway.
• Doesn't make sense to do it only for underlines. All (useful) TextAttributes should be read and copied. (TextAtributes properties that cannot be represented in HTML can be ignored.)