Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions UI ship list #15845

Open
18 of 29 tasks
zadjii-msft opened this issue Aug 17, 2023 · 1 comment
Open
18 of 29 tasks

Suggestions UI ship list #15845

zadjii-msft opened this issue Aug 17, 2023 · 1 comment
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 17, 2023 •
edited
Loading

first PR: #14938

1.21 Ship list
Preview Give feedback
  3. Backspaces we insert into a command for a useCommandline suggestion show up in the suggestions UI #16577
    Area-Suggestions In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
    zadjii-msft
  4. Command Palette and SXNUI wont match sendInput actions with a space in them #16578
    Area-Suggestions In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
    zadjii-msft
  5. The suggestions UI counts the current command as one of the recent commands #17243
    In-PR Needs-Tag-Fix Needs-Triage
  6. The suggestions UI is populated with trailing spaces when useCommandline: true #17241
    In-PR Needs-Tag-Fix Needs-Triage Priority-0 Product-Terminal Severity-Blocking

1.22
Preview Give feedback
  2. sendInput should be previewable #12861
    Area-CmdPal Area-Settings Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Terminal
    zadjii-msft
  3. Add descriptions to commands (namely, snippets) #17376
  4. when useCommandline, trim the CurrentCommand at the cursor pos (to prevent pwsh ghost text from populating menu) #17772
    In-PR Needs-Author-Feedback Needs-Tag-Fix Needs-Triage
  5. Dismiss a action preview when the next action isn't previewable #17533
  6. Filtering the search to display 0 actions does not clear the preview #17773
    In-PR Needs-Author-Feedback Needs-Tag-Fix Needs-Triage
  7. Turn autoMarkPrompts on by default in 1.22 #17632
    Area-Suggestions In-PR Issue-Task Needs-Tag-Fix Product-Terminal
    zadjii-msft

1.23
Preview Give feedback
  4. Snippets & useCommandline don't account for grapheme clusters quite right #17419
    Area-Suggestions Issue-Bug Needs-Tag-Fix Product-Terminal
    zadjii-msft

Related
Preview Give feedback
  1. Fragments should be able to add actions #16063
    Area-Settings In-PR Issue-Feature Needs-Tag-Fix Product-Terminal
    zadjii-msft
  2. Allow sendInput to have promptable sections for further completion #12927
    Area-CmdPal Area-Extensibility Area-Settings Issue-Feature Product-Terminal
  5. Pasting a multiline block of text does not autoMarkPrompts #15813
    Area-TerminalControl Issue-Bug Product-Terminal Resolution-By-Design
    zadjii-msft
  6. Allow 3p suggestion sources #17344
    Area-Extensibility Issue-Scenario Product-Terminal

Other notes:

are you looking for me?
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Aug 17, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone Aug 17, 2023
@zadjii-msft zadjii-msft self-assigned this Aug 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 17, 2023
@zadjii-msft zadjii-msft mentioned this issue Aug 17, 2023
Merged
4 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 17, 2023
DHowett pushed a commit that referenced this issue Aug 24, 2023
@zadjii-msft
A first couple Suggestion UI nits (#15848)
7a05501 
Closes the active checkboxes in #15845. I'll leave that open till we get
to the endgame, I'm sure more will show up.

Closes:

- [x] Accessibility tags all have `CommandPalette_` strings 🤣 
- [x] useCommandline should leave the cursor at the _end_ of the input,
not at the start
- [x] useCommandline, when bottom-up, should leave the _last_ list item
selected, not the first.
- [x] ^ Probably applies to any changes to the filter text when bottom
up.
@zadjii-msft zadjii-msft mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@zadjii-msft
Remove the animations from the suggestions UI (#17247)
46526bc 
gotta go fast, and these animations are not fast

noted in #15845
DHowett pushed a commit that referenced this issue May 13, 2024
@zadjii-msft @DHowett
Remove the animations from the suggestions UI (#17247)
ece2ef7 
gotta go fast, and these animations are not fast

noted in #15845

(cherry picked from commit 46526bc)
Service-Card-Id: 92546875
Service-Version: 1.21
This was referenced May 28, 2024
Merged
Open
@zadjii-msft zadjii-msft mentioned this issue Jun 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
@zadjii-msft
Add descriptions to commands (namely, snippets) (#17376)
a7e2b46 
This adds a `"description"` property to actions. Notably, the shell
completion protocol (#3121) will now also populate that.

The suggestions UI can then use those descriptions to display an
additional tooltip with that information.

TeachingTip was kinda an abject disaster last time I tried this, so this
_isn't_ a TeachingTip. It's literally a text block.

xlinks:
* #13000
* #15845 
* #14939 - the last abandoned attempt at this
github-merge-queue bot pushed a commit that referenced this issue Jun 22, 2024
@zadjii-msft @DHowett
Add a spec for "Snippets" (#17329)
8511f3d 
This specs out a lot of plans for snippets. We've already got these in
the sxnui as "tasks", but we can do so very much more.

This spec is a few years old now, but it's time for it to get promoted
out of my draft branch.

References: 
* #1595
* #7039
* #3121
* #10436
* #12927
* #12857
* #5790
* #15845

---------

Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
@zadjii-msft zadjii-msft mentioned this issue Jul 1, 2024
Open
@zadjii-msft zadjii-msft mentioned this issue Jul 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 9, 2024
@zadjii-msft
Dismiss a action preview when the next action isn't previewable (#17533)
678432a 
This became much more obvious with the sendInput previewing. We would
only dismiss previews if the following action was also previewable.

related: #15845
@DHowett
Copy link
Member

DHowett commented Aug 22, 2024

@zadjii-msft can you punt the 1.21 and 1.22 things to the appropriate milestone and move this issue out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

No branches or pull requests
2 participants
@DHowett @zadjii-msft