Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with "Open windows from a previous session" and defaults profile run as admin #14932

Open
Quenom opened this issue Feb 28, 2023 · 6 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.

Comments

@Quenom
Copy link

Quenom commented Feb 28, 2023

Windows Terminal version

1.16.10261.0

Windows build number

10.0.19045.2604

Other Software

No response

Steps to reproduce

Set "When Terminal Starts" to "open windows from a previous session"
Set Defaults to run this profile as administrator

Expected Behavior

When opening terminal from start menu it opens as administrator with saved tabs

Actual Behavior

Terminal opens with default profile and new window with previous tabs.
This happens even with saved tab being the startup default

@Quenom Quenom added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 28, 2023
@Quenom
Copy link
Author

Quenom commented Feb 28, 2023

I think it might be similar to #14861 and #14799
Could setting be added to run terminal itself as administrator, and not profiles? As there is no way to set default way microsoft store apps open

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-2 A description (P2) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 1, 2023
@zadjii-msft zadjii-msft removed their assignment Mar 1, 2023
@mtaalas
Copy link

mtaalas commented Jun 4, 2023

I have this as well on the exact same specifications.

Expected behavior is that the old session starts (if "load previous session" is configured) 1:1 without any new windows or tabs UNLESS I exclusively tell it to do something else. :)

@mtaalas
Copy link

mtaalas commented Jun 4, 2023

I think I see the real issue in my case.

I've installed Terminal from windows store to get auto updates and it has created an app shortcut (or it's not really a shortcut in a normal sense) that calls the terminal with the following:

"c:\Program Files\WindowsApps\Microsoft.WindowsTerminal_(version)\windowsTerminal.exe" new-tab --profile [profile path]

So t's exclusively asking to launch a new tab when it's opened... but I've never set it up to do that.

I cannot change these parameters in any way.. it seems to be hard coded. I can only see this because it's trying to run as admin and I select "show details" on UAC prompt.

I'm still not sure what type of shortcut / program this is (I'm not familiar with windows store peculiarities) but these seem to come when you install the terminal using the store.

Can someone confirm or explain what's going on?

@zadjii-msft
Copy link
Member

@mtaalas Sorry, just seeing that comment after getting back from leave.

That looks to me like you've got the Terminal set up to run your default profile elevated (as admin) by default. In that case, when you launch the Terminal unelevated, it needs to explicitly shell out to create another new instance of the Terminal as admin. When that happens, it explicitly passes new-tab -p {{profile_guid}} as the args, so that the new terminal window gets created with the correct profile.

Now, maybe there's an easy solution here - when the Terminal is getting launched elevated for the default profile, maybe we shouldn't pass those args? That'd cause the Terminal to start up, and either

  • use the ELEVATED windows from last time, if there are any (and that setting is turned on)
  • just make a single window with the default profile (elevated)

Right now, because we are passing the new-tab -p {{blah}}, that tells the terminal EXPLICITLY "I want something new ({{blah}}), also, bring back what I had before"

@Serat00l951
Copy link

Hello guys. Is there any ETA of fixing this bug? I have encountered this bug in 1.17 (#15738) and it still exists in 1.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants