Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Admin-specific customizations #11111

Open
DHowett opened this issue Sep 1, 2021 · 2 comments
Open

[Epic] Admin-specific customizations #11111

DHowett opened this issue Sep 1, 2021 · 2 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Scenario Product-Terminal The new Windows Terminal.
Milestone

Comments

@DHowett
Copy link
Member

DHowett commented Sep 1, 2021

written and maintained by @carlos-zamora & @zadjii-msft

For quite some time now, we've gotten requests for admin-specific customizations. The first being to have an "appearance config" for an elevated session. However, we stopped working on that when we hit the following problem: how do we determine which appearance config to choose when a user is in an elevated session and also has an unfocused appearance config?

Over time, we've gotten more requests with similar situations (not necessarily limited to appearance config). This epic tracks these requests:


zadjii-msft notes:
Nexus of weird elevate:true bugs:


User stories

  • I want the Terminal to have a different set of profiles in the dropdown when running elevated (vs regularly)
  • I want a different defaultProfile when running elevated
  • I want to use a different profile.defaults block when running elevated
  • I want a profile to have a different appearance when running elevated
  • I want the Terminal itself to have a different theme when running elevated

Open questions

  • Is this prone to a combinatiorial explosion of situational settings? YES IT IS
    • Would there ever be a case for like, {container}DefaultProfile? (like UWP? this is an intentionally dumb example)
    • How would (focused, unfocused) x (elevated, unelevated) appearances work? That's already 4 different states.
    • (focused, unfocused) x (elevated, unelevated) x (light, dark) x (readonly, not) Lock-Symbol for read-only panes #16554
  • Should these all be in the base settings file, or a separate settings file?
    • IE, should we have
      • elevatedTheme, elevatedDefaultProfile, profiles.elevatedDefaults OR
      • admin-settings.json
    • Should there be a entirely separate globals block for elevated settings, ala Add per-window-name global settings #9992?

Other Admin QoL issues

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 1, 2021
@zadjii-msft zadjii-msft added ⛺ Reserved For future use and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 2, 2021
@carlos-zamora carlos-zamora changed the title <camper> [Epic] Admin-specific customizations Feb 2, 2023
@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Scenario and removed Needs-Tag-Fix Doesn't match tag requirements ⛺ Reserved For future use labels Feb 2, 2023
@carlos-zamora carlos-zamora added this to the Backlog milestone Feb 2, 2023
@carlos-zamora
Copy link
Member

We definitely need a spec for this. One fairly extreme idea I had was to introduce an admin-settings.json.

  • if admin-settings.json exists, load that. Otherwise, use settings.json.
  • settings UI modifies the loaded JSON
  • when "import JSON" is eventually a feature in the settings UI, it'll be easier to migrate settings from one settings.json to another

I'm down for a more clever solution, but it seems like users want a completely customizable experience between their elevated prompt and non-elevated prompt. So might as well enable that experience? Especially since loading a different JSON would be trivial.

@zadjii-msft
Copy link
Member

idea

"showWhenElevated": false | (true | "both") | "only"

  • false: don't show a profile when elevated
  • true / "both": show this profile both when elevated and when running normally
  • only: Only show this profile when we're running elevated

Then just screw it with the appearance config on the existing profile - just have two different profiles.
Maybe when Dustin gets the itch to do separate appearance vs "task"s, then the two profiles could have different appearances, but the same "task".

this has been thoughts with Luca, who has kept me up since 3am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Scenario Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants