Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fonts on HTML format pasting #14762

Closed
alfonskunk opened this issue Jan 30, 2023 · 2 comments · Fixed by #15046
Closed

Small fonts on HTML format pasting #14762

alfonskunk opened this issue Jan 30, 2023 · 2 comments · Fixed by #15046
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.18

Comments

@alfonskunk
Copy link

alfonskunk commented Jan 30, 2023 •
edited
Loading

Windows Terminal version

1.17.1023

Windows build number

10.0.19044.2486

Other Software

No response

Steps to reproduce

Copying text with 10px font size on Windows Terminal Preview
With AltasEngine = true it pastes with 5px font size (mantain rest of text format like colors and font type)
With AtlasEngine = false it pastes with 1px font size (mantain rest of text format like colors and font type)

Copying text with 20px font size on Windows Terminal Preview
With AltasEngine = true it pastes with 9px font size (mantain rest of text format like colors and font type)
With AtlasEngine = false it pastes with 1px font size (mantain rest of text format like colors and font type)

RTF pastes right font size.

This issue is reproducible only since 1.17.1023 at 2023/01/25

Expected Behavior

Pasting with same font size as source

Actual Behavior

With AltasEngine = true it pastes with 5px font size (mantain rest of text format like colors and font type)
With AtlasEngine = false it pastes with 1px font size (mantain rest of text format like colors and font type)
@alfonskunk alfonskunk added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 30, 2023
@carlos-zamora carlos-zamora added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 1, 2023
@carlos-zamora carlos-zamora added this to the Terminal v1.18 milestone Feb 1, 2023
@carlos-zamora carlos-zamora added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues and removed Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) labels Feb 1, 2023
@carlos-zamora
Copy link
Member

The renderer hands the size of the font over when copying HTML text to the clipboard.

We should also check if this affects 1.16

@alfonskunk
Copy link
Author

Hi,

1.16 is not affected.
And neither does Windows Terminal Stable (1.15.3465.0)

@j4james j4james mentioned this issue Mar 25, 2023
Closed
@lhecker lhecker mentioned this issue Mar 26, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Mar 26, 2023
DHowett pushed a commit that referenced this issue Mar 27, 2023
@lhecker
Fix font size of HTML clipboard contents (#15046)
d9efdae 
This regression is caused by 0eff8c0. It previously said `.Y` here.
I went through the diff again and found no other width/height mistake.

Closes #14762
Closes #15043
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Mar 27, 2023
DHowett pushed a commit that referenced this issue Mar 31, 2023
@lhecker @DHowett
Fix font size of HTML clipboard contents (#15046)
799d48f 
This regression is caused by 0eff8c0. It previously said `.Y` here.
I went through the diff again and found no other width/height mistake.

Closes #14762
Closes #15043

(cherry picked from commit d9efdae)
Service-Card-Id: 88652707
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Fix font size of HTML clipboard contents microsoft/terminal
2 participants
@carlos-zamora @alfonskunk