Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.17] Crash with Voice Access launch #14504

Closed
carlos-zamora opened this issue Dec 7, 2022 · 1 comment · Fixed by #14534
Closed

[1.17] Crash with Voice Access launch #14504

carlos-zamora opened this issue Dec 7, 2022 · 1 comment · Fixed by #14534
Assignees
@zadjii-msft
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.17

Comments

@carlos-zamora
Copy link
Member

Windows Terminal version

commit da2b80b

Windows build number

10.0.25262.0

Other Software

No response

Steps to reproduce

  1. Open WT Dev build
  2. Open voice access (must have been closed)
  3. Crash!

Expected Behavior

No crash

Actual Behavior

Crash here:

terminal/src/cascadia/WindowsTerminal/IslandWindow.cpp

Line 663 in da2b80b

const std::wstring param{ (wchar_t*)lparam };

@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. Area-Windowing Window frame, quake mode, tearout labels Dec 7, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.17 milestone Dec 7, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 7, 2022
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 7, 2022
@microsoft microsoft deleted a comment Dec 8, 2022
@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Dec 12, 2022
@zadjii-msft zadjii-msft mentioned this issue Dec 12, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Dec 12, 2022
@ghost ghost closed this as completed in #14534 Dec 12, 2022
ghost pushed a commit that referenced this issue Dec 12, 2022
@zadjii-msft
Don't crash when turning on Voice Access (#14534)
58ce22d 
I should have checked the `wparam`. 

Regressed in #14064.

Tested manually. No more crashy. 

Closes #14504
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 12, 2022
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14534, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

Don't crash when turning on Voice Access microsoft/terminal
2 participants
@carlos-zamora @zadjii-msft