Duplicating inactive tab duplicates active one #13942
Labels
Area-UserInterface
Issues pertaining to the user interface of the Console or Terminal
Help Wanted
We encourage anyone to jump in on these.
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Tag-Fix
Doesn't match tag requirements
Priority-2
A description (P2)
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
serd2011
added
the
Issue-Bug
ghost
added
Needs-Triage
|
Huh. That's... not right. This was sorta reported before in #13579, but we pivoted that thread to be more about split pane, rather than the inactive tab thing. This is also an issue. Thanks for filing! |
zadjii-msft
added
Help Wanted
zadjii-msft
removed
the
Needs-Triage
DHowett
pushed a commit
that referenced
this issue
Oct 11, 2022
Instead of using the currently focused tab when an unfocused tab is duplicated, the `_MakePane(...)` function now uses an optional source tab argument that points to the correct tab being duplicated. ## Validation Steps Performed Manually tested on multiple tabs with different profiles. Performed steps: * Construct at least two tabs with different profiles. * Select `Duplicate Tab` option from the dropdown menu of the unfocused tab. * Verify that the new tab has the same profile as the tab it was duplicated from. Closes #13942
ghost
added
Resolution-Fix-Committed
DHowett
pushed a commit
that referenced
this issue
Oct 12, 2022
Instead of using the currently focused tab when an unfocused tab is duplicated, the `_MakePane(...)` function now uses an optional source tab argument that points to the correct tab being duplicated. ## Validation Steps Performed Manually tested on multiple tabs with different profiles. Performed steps: * Construct at least two tabs with different profiles. * Select `Duplicate Tab` option from the dropdown menu of the unfocused tab. * Verify that the new tab has the same profile as the tab it was duplicated from. Closes #13942 (cherry picked from commit 8f08bb0) Service-Card-Id: 86159036 Service-Version: 1.15
DHowett
pushed a commit
that referenced
this issue
Oct 13, 2022
Instead of using the currently focused tab when an unfocused tab is duplicated, the `_MakePane(...)` function now uses an optional source tab argument that points to the correct tab being duplicated. ## Validation Steps Performed Manually tested on multiple tabs with different profiles. Performed steps: * Construct at least two tabs with different profiles. * Select `Duplicate Tab` option from the dropdown menu of the unfocused tab. * Verify that the new tab has the same profile as the tab it was duplicated from. Closes #13942 (cherry picked from commit 8f08bb0) Service-Card-Id: 86159037 Service-Version: 1.16
|
🎉This issue was addressed in #13964, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #13964, which has now been successfully released as Handy links: |
3 tasks
zadjii-msft
added a commit
that referenced
this issue
Aug 24, 2023
This PR's goal is to allow something like a `Tab` to raise a ShortcutAction, by saying "this action should be performed on ME". We've had a whole category of these issues in the past: * #15734 * #15760 * #13579 * #13942 * #13942 * Heck even dating back to #10832 So, this tries to remove a bit of that footgun. This probably isn't the _final_ form of what this refactor might look like, but the code is certainly better than before. Basically, there's a few bits: * `ShortcutActionDispatch.DoAction` now takes a `sender`, which can be _anything_. * Most actions that use a "Get the focused _thing_ then do something to it" are changed to "If there was a sender, let's use that - otherwise, we'll use the focused _thing_". * TerminalTab was largely refactored to use this, instead of making requests to the `TerminalPage` to just do a thing to it. I've got a few TODO!s left, but wanted to get initial feedback. * [x] `TerminalPage::_HandleTogglePaneZoom` * [x] `TerminalPage::_HandleFocusPane` * [x] `TerminalPage::_MoveTab` Closes #15734
DHowett
pushed a commit
that referenced
this issue
Sep 22, 2023
This PR's goal is to allow something like a `Tab` to raise a ShortcutAction, by saying "this action should be performed on ME". We've had a whole category of these issues in the past: * #15734 * #15760 * #13579 * #13942 * #13942 * Heck even dating back to #10832 So, this tries to remove a bit of that footgun. This probably isn't the _final_ form of what this refactor might look like, but the code is certainly better than before. Basically, there's a few bits: * `ShortcutActionDispatch.DoAction` now takes a `sender`, which can be _anything_. * Most actions that use a "Get the focused _thing_ then do something to it" are changed to "If there was a sender, let's use that - otherwise, we'll use the focused _thing_". * TerminalTab was largely refactored to use this, instead of making requests to the `TerminalPage` to just do a thing to it. I've got a few TODO!s left, but wanted to get initial feedback. * [x] `TerminalPage::_HandleTogglePaneZoom` * [x] `TerminalPage::_HandleFocusPane` * [x] `TerminalPage::_MoveTab` Closes #15734 (cherry picked from commit 30eb9ee) Service-Card-Id: 90438493 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows Terminal version
1ef4a42
Steps to reproduce
Expected Behavior
New tab created with inactive tab's profile
Actual Behavior
New tab created with active tab's profile
The text was updated successfully, but these errors were encountered: