If you rename the tab and then click on Export Text, the filename is the previous title of the tab

[MontecaE]

Windows Terminal version

1.14.2281.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

Title of a tab is Administrator: PowerShell

• rename it to asd
• click on Export Text
• (default) filename is Administrator: PowerShell.txt

Expected Behavior

The (default) filename exported is the tab name (so, in this example asd.txt)

Actual Behavior

The filename is not aligned to the tab title

[zadjii-msft]

Should be easy enough to fix:

terminal/src/cascadia/TerminalApp/TabManagement.cpp

Lines 399 to 439 in fe0d570

	winrt::fire_and_forget TerminalPage::_ExportTab(const TerminalTab& tab, winrt::hstring filepath)
	{
	// This will be used to set up the file picker "filter", to select .txt
	// files by default.
	static constexpr COMDLG_FILTERSPEC supportedFileTypes[] = {
	{ L"Text Files (*.txt)", L"*.txt" },
	{ L"All Files (*.*)", L"*.*" }
	};
	// An arbitrary GUID to associate with all instances of this
	// dialog, so they all re-open in the same path as they were
	// open before:
	static constexpr winrt::guid clientGuidExportFile{ 0xF6AF20BB, 0x0800, 0x48E6, { 0xB0, 0x17, 0xA1, 0x4C, 0xD8, 0x73, 0xDD, 0x58 } };
	try
	{
	if (const auto control{ tab.GetActiveTerminalControl() })
	{
	auto path = filepath;
	if (path.empty())
	{
	// GH#11356 - we can't use the UWP apis for writing the file,
	// because they don't work elevated (shocker) So just use the
	// shell32 file picker manually.
	path = co_await SaveFilePicker(*_hostingHwnd, [control](auto&& dialog) {
	THROW_IF_FAILED(dialog->SetClientGuid(clientGuidExportFile));
	try
	{
	// Default to the Downloads folder
	auto folderShellItem{ winrt::capture<IShellItem>(&SHGetKnownFolderItem, FOLDERID_Downloads, KF_FLAG_DEFAULT, nullptr) };
	dialog->SetDefaultFolder(folderShellItem.get());
	}
	CATCH_LOG(); // non-fatal
	THROW_IF_FAILED(dialog->SetFileTypes(ARRAYSIZE(supportedFileTypes), supportedFileTypes));
	THROW_IF_FAILED(dialog->SetFileTypeIndex(1)); // the array is 1-indexed
	THROW_IF_FAILED(dialog->SetDefaultExtension(L"txt"));
	// Default to using the tab title as the file name
	std::wstring filename{ control.Title() };
	filename = til::clean_filename(filename);
	THROW_IF_FAILED(dialog->SetFileName((filename + L".txt").c_str()));

Just use the tab's Title, rather than the control's Title, on line 437.

[ghost]

🎉This issue was addressed in #13915, which has now been successfully released as Windows Terminal v1.15.252.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉This issue was addressed in #13915, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

• Release Notes
• Store Download