Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings]: Screen Reader is not announcing Breadcrumb control's name throughout Settings page. #13826

Closed
ghost opened this issue Aug 23, 2022 · 5 comments · Fixed by #14180
Closed

[Settings]: Screen Reader is not announcing Breadcrumb control's name throughout Settings page. #13826

ghost opened this issue Aug 23, 2022 · 5 comments · Fixed by #14180
Labels
A11yCO Accessibility tracking A11ySev1 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Disability-Mobility Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.17

Comments

@ghost
Copy link

ghost commented Aug 23, 2022

Windows Terminal version

1.15.2003.0

Windows build number

10.0.25179.1000

Other Software

Test Environment:
OS: Window 11 22H2 OS Build 25179.1000
App: Windows Terminal Preview
AT: Narrator and Voice Access

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Voice Access AT.
  3. Inside Settings> Defaults >Appearance page, navigate to Defaults control and observe the issue.
  4. Navigate to other breadcrumb control throughout the Terminal app and observe the issue.

User Experience:
People with Visual impairments like Screen Reader will be impacted here as well as they will not be able to know the purpose of control.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachments:
Unnammed Breadcrumb control.zip

Expected Behavior

Screen Reader should announce Breadcrumb control's name throughout Settings page.

For 'Defaults' Control in 'Defaults> Appearance', Screen Reader is announcing 'Defaults, link, Breadcrumb bar item 1 of 2'

Actual Behavior

Screen Reader is not announcing Breadcrumb control's name throughout Settings page.

For 'Defaults' Control in 'Defaults> Appearance', Screen Reader is announcing 'Breadcrumb bar item 1 of 2'

Observation: Issue repro with JAWS and NVDA Screen Reader.
@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yCO Accessibility tracking A11ySev1 Accessibility tracking A11yMAS Accessibility tracking Disability-Mobility Accessibility tracking Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 23, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Aug 23, 2022
@zadjii-msft zadjii-msft added the Priority-1 A description (P1) label Aug 23, 2022
@Priyanka-Chauhan123 Priyanka-Chauhan123 added A11yWCAG Accessibility tracking and removed A11yMAS Accessibility tracking labels Aug 30, 2022
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 10, 2022
@carlos-zamora carlos-zamora mentioned this issue Oct 11, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 11, 2022
@ghost ghost closed this as completed in #14180 Oct 11, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 11, 2022
ghost pushed a commit that referenced this issue Oct 11, 2022
@carlos-zamora
Make SUI breadcrumb readable by screen readers (#14180)
30046dd 
The breadcrumbs in the SUI were not readable by screen readers because they are represented as a button with a text block inside of it. Turns out, if you make the DataTemplate's item `IStringable` (meaning it has a `ToString()`), it all magically works! Allowing the screen reader to read the button as text.

Closes #13826
DHowett pushed a commit that referenced this issue Oct 12, 2022
@carlos-zamora @DHowett
Make SUI breadcrumb readable by screen readers (#14180)
c25cd5c 
The breadcrumbs in the SUI were not readable by screen readers because they are represented as a button with a text block inside of it. Turns out, if you make the DataTemplate's item `IStringable` (meaning it has a `ToString()`), it all magically works! Allowing the screen reader to read the button as text.

Closes #13826

(cherry picked from commit 30046dd)
Service-Card-Id: 86158951
Service-Version: 1.15
DHowett pushed a commit that referenced this issue Oct 13, 2022
@carlos-zamora @DHowett
Make SUI breadcrumb readable by screen readers (#14180)
e376f8c 
The breadcrumbs in the SUI were not readable by screen readers because they are represented as a button with a text block inside of it. Turns out, if you make the DataTemplate's item `IStringable` (meaning it has a `ToString()`), it all magically works! Allowing the screen reader to read the button as text.

Closes #13826

(cherry picked from commit 30046dd)
Service-Card-Id: 86158952
Service-Version: 1.16
@ghost
Copy link

ghost commented Oct 18, 2022

🎉This issue was addressed in #14180, which has now been successfully released as Windows Terminal v1.15.2874.:tada:

Handy links:

@ghost
Copy link
Author

ghost commented Oct 19, 2022

Hi @carlos-zamora In Windows Terminal v1.15.2874(mentioned build in above comment) it is fixed but In Window Terminal Preview Version: 1.16.2642.0(mentioned Store Download link) it is not fixed, Is that fine?

Also let us know for all other bugs whether we have verify on Normal, Preview or both.

@DHowett
Copy link
Member

DHowett commented Oct 19, 2022

@v-rpundir We will release the Preview update soon. We have been focusing on making Stable version better for the Windows 11 22H2 update. Thanks for testing. :)

@Shubham786786
Copy link

Closing the bug as issue is fixed on the latest terminal build.

@Shubham786786 Shubham786786 added the A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. label Nov 14, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14180, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11yCO Accessibility tracking A11ySev1 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Disability-Mobility Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

Make SUI breadcrumb readable by screen readers microsoft/terminal
5 participants
@DHowett @carlos-zamora @zadjii-msft @Priyanka-Chauhan123 @Shubham786786