Inactive tab BG color (tab.inactiveBackground)
#13684
Assignees
Labels
Area-Theming
Anything related to the theming of elements of the window
Issue-Task
It's a feature request, but it doesn't really need a major design.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
27 tasks
ghost
added
Needs-Triage
zadjii-msft
changed the title
tab.inactiveBackground) - important, because when unset, the tab will use the active Background color to create an inactive BG, which maybe isn't what we want. Consider - a bright cyan active BG, transparent inactiveBG, and terminalBG for the tabRow bg.tab.inactiveBackground)
zadjii-msft
added
Product-Terminal
DHowett
removed
the
Needs-Triage
zadjii-msft
added a commit
that referenced
this issue
Aug 31, 2022
Does what it sounds like on the label. This is important, because when unset, the tab will use the active `Background` color to create an inactive BG, which maybe isn't what we want. Consider: - a bright cyan active BG, - and `terminalBG` for the `tabRow` bg. Without an unfocusedBackground setting, all the tabs will still appear cyan when unfocused, which is extra gross. As a judgement call, I made `terminalBackground` and `accent` use 30% opacity when set, to match the existing coloration. See also #13554. If we want to make the default theme `tab.background: terminalBackground`, we should make `tab.unfocusedBackground` transparent (`#00000000`) by default. Otherwise, a Campell (`#0c0c0c`) tab on _any_ tab row will still have a faint tab visible. * closes #13684 * closes #13246 * tested manually This also does a lot of code shuffling, to get SettingsUI tabs to behave sensibly. We want those tabs to have (`#0c0c0c`, `#ffffff`) colored BGs for `terminalBackground` (see mail thread). We also don't want dark focused tabs colors, combined with light tab row colors, combined with transparent unfocused tabs, to result in unfocused tabs having white-on-white text. That's gross. So that's been added to this PR in b38b704.
ghost
added
Resolution-Fix-Committed
|
🎉This issue was addressed in #13689, which has now been successfully released as Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Important, because when unset, the tab will use the active Background color to create an inactive BG, which maybe isn't what we want. Consider - a bright cyan active BG, transparent
inactiveBG, andterminalBGfor thetabRowbg.See also #13554. If we want to make the default theme
tab.background: terminalBackground, we should make this transparent by default.The text was updated successfully, but these errors were encountered: