Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not display Emacs's font lock correctly #13643

Closed
Tracked by #13661
ygohko opened this issue Aug 1, 2022 · 2 comments
Closed
Tracked by #13661

Can not display Emacs's font lock correctly #13643

ygohko opened this issue Aug 1, 2022 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@ygohko
Copy link

ygohko commented Aug 1, 2022

Windows Terminal version

1.14.1963.0

Windows build number

10.0.22000.795

Other Software

GNU Emacs 27.1 (inside WSL)

Steps to reproduce

Install GNU Emacs 27.1 in WSL and launch it with attached .emacs file. Then load a attached TestFontLock.c file.

dot_emacs.txt
TestFontLock.c.txt

Expected Behavior

Displaying result in legacy cmd window is below.

LegacyCmd

Actual Behavior

Displaying result in Windows Terminal is below. Font locking for tab characters is not shown correctly, and menu bar is also strange.

Terminal

This issue may be occurred in latest version because I have found it in these days.
@ygohko ygohko added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Aug 1, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 1, 2022
@zadjii-msft
Copy link
Member

/dup #13229

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2022
@ghost
Copy link

ghost commented Aug 1, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 1, 2022
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 1, 2022
@zadjii-msft zadjii-msft mentioned this issue Aug 3, 2022
Merged
2 tasks
ghost pushed a commit that referenced this issue Aug 5, 2022
@zadjii-msft
Fix the ConPTY extended attributes optimization (#13661)
ffe9a0f 
... which should have never worked in the first place


Quick filing a PR for review. This is the bulk of the actual code changes. Figured it was best to review the conpty changes sooner than later and I can add tests in the morning.

Test cases:
```
printf "\e[7m         test         \e[m\n"
```

```
printf "\e[7m"; printf ' %.0s' $(seq 1 $COLUMNS); printf "\e[m\n"
```

After:
![image](https://user-images.githubusercontent.com/18356694/182478185-6e65ab99-5c27-4772-af3b-2baa22387ec1.png)


Closes #13229


Definitely fixes:
* [x] #13643
* [x] PowerShell/PowerShell#17812
DHowett pushed a commit that referenced this issue Aug 8, 2022
@zadjii-msft @DHowett
Fix the ConPTY extended attributes optimization (#13661)
fff3372 
... which should have never worked in the first place

Quick filing a PR for review. This is the bulk of the actual code changes. Figured it was best to review the conpty changes sooner than later and I can add tests in the morning.

Test cases:
```
printf "\e[7m         test         \e[m\n"
```

```
printf "\e[7m"; printf ' %.0s' $(seq 1 $COLUMNS); printf "\e[m\n"
```

After:
![image](https://user-images.githubusercontent.com/18356694/182478185-6e65ab99-5c27-4772-af3b-2baa22387ec1.png)

Closes #13229

Definitely fixes:
* [x] #13643
* [x] PowerShell/PowerShell#17812

(cherry picked from commit ffe9a0f)
Service-Card-Id: 84736231
Service-Version: 1.15
PKRoma pushed a commit to PKRoma/Terminal that referenced this issue Oct 15, 2022
@zadjii-msft @DHowett
Fix the ConPTY extended attributes optimization (microsoft#13661)
4948f25 
... which should have never worked in the first place

Quick filing a PR for review. This is the bulk of the actual code changes. Figured it was best to review the conpty changes sooner than later and I can add tests in the morning.

Test cases:
```
printf "\e[7m         test         \e[m\n"
```

```
printf "\e[7m"; printf ' %.0s' $(seq 1 $COLUMNS); printf "\e[m\n"
```

After:
![image](https://user-images.githubusercontent.com/18356694/182478185-6e65ab99-5c27-4772-af3b-2baa22387ec1.png)

Closes microsoft#13229

Definitely fixes:
* [x] microsoft#13643
* [x] PowerShell/PowerShell#17812

(cherry picked from commit ffe9a0f)
Service-Card-Id: 84736231
Service-Version: 1.15
(cherry picked from commit fff3372)
Service-Card-Id: 84736230
Service-Version: 1.14
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ygohko @zadjii-msft