Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting launch mode to full screen also applies to Quake mode #12894

Closed
Tracked by #8888
nathpete-msft opened this issue Apr 12, 2022 · 3 comments · Fixed by #13473
Closed
Tracked by #8888

Setting launch mode to full screen also applies to Quake mode #12894

nathpete-msft opened this issue Apr 12, 2022 · 3 comments · Fixed by #13473
Labels
Area-Windowing Window frame, quake mode, tearout Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@nathpete-msft
Copy link
Member

Windows Terminal version

1.13.10983.0

Windows build number

10.0.19043.0

Other Software

No response

Steps to reproduce

  1. In Terminal settings, set: Startup > Launch Mode > Full Screen
  2. Summon the Quake window

Expected Behavior

I wouldn't expect Quake mode sizing to be affected by the Terminal launch mode.

Actual Behavior

Quake mode opens in full screen.

Apologies if this is a duplicate, I didn't see it mentioned in #8888 and it's different than #10199.
@nathpete-msft nathpete-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Apr 12, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 12, 2022
@zadjii-msft
Copy link
Member

Yep this is a real bug we should fix. Thanks!

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Windowing Window frame, quake mode, tearout labels Apr 13, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 13, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 13, 2022
Open
61 tasks
@zadjii-msft zadjii-msft added this to the Backlog milestone Apr 13, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 13, 2022
@davidegiacometti davidegiacometti mentioned this issue Jul 9, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 9, 2022
@ghost ghost closed this as completed in #13473 Jul 11, 2022
ghost pushed a commit that referenced this issue Jul 11, 2022
@davidegiacometti
Don't set full screen to quake window (#13473)
589286a 
If launch mode is set to full screen quake window is opened in full
screen.

## Validation Steps Performed
- Set startup > launch mode > full screen
- Launch quake window
- Quake window shouldn't be opened in full screen

Closes #12894
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 11, 2022
DHowett pushed a commit that referenced this issue Jul 15, 2022
@davidegiacometti @DHowett
Don't set full screen to quake window (#13473)
f1b75e5 
If launch mode is set to full screen quake window is opened in full
screen.

## Validation Steps Performed
- Set startup > launch mode > full screen
- Launch quake window
- Quake window shouldn't be opened in full screen

Closes #12894

(cherry picked from commit 589286a)
Service-Card-Id: 84116409
Service-Version: 1.14
DHowett pushed a commit that referenced this issue Jul 19, 2022
@davidegiacometti @DHowett
Don't set full screen to quake window (#13473)
88b527f 
If launch mode is set to full screen quake window is opened in full
screen.

## Validation Steps Performed
- Set startup > launch mode > full screen
- Launch quake window
- Quake window shouldn't be opened in full screen

Closes #12894

(cherry picked from commit 589286a)
Service-Card-Id: 84116410
Service-Version: 1.15
@ghost
Copy link

ghost commented Aug 5, 2022

🎉This issue was addressed in #13473, which has now been successfully released as Windows Terminal v1.14.196.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 5, 2022

🎉This issue was addressed in #13473, which has now been successfully released as Windows Terminal Preview v1.15.200.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Don't set full screen to quake window
2 participants
@zadjii-msft @nathpete-msft