Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing the right arrow in the commandline mode of the cmdpal should fill in the selected command #11049

Closed
Tracked by #5400
zadjii-msft opened this issue Aug 26, 2021 · 4 comments · Fixed by #11069
Closed
Tracked by #5400

Pressing the right arrow in the commandline mode of the cmdpal should fill in the selected command #11049

zadjii-msft opened this issue Aug 26, 2021 · 4 comments · Fixed by #11069
Labels
Area-CmdPal Command Palette issues and features Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@zadjii-msft
Copy link
Member

Okay guys CRAZY IDEA TIME.

Been playing with the commandline mode more and more as working on features. I find myself typing part of a command that's in history, then arrow downing to it, but then I want to make a change to that command. And instinctively, I hit →. I guess I think that will fill in the entirety of the command I currently have highlighted. Then I could add to it, or go back and change a small part of it.

Is that totally insane? It's like tab completion, sorta? But we can't use tab in that UI element, so it's gotta be something else.

<discuss>
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CmdPal Command Palette issues and features Needs-Discussion Something that requires a team discussion before we can proceed labels Aug 26, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 26, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 26, 2021
@zadjii-msft zadjii-msft mentioned this issue Aug 26, 2021
Open
52 tasks
@Don-Vito
Copy link
Contributor

@zadjii-msft - Not insane at all, but the question if it is intuitive enough 😊

@DHowett
Copy link
Member

DHowett commented Aug 26, 2021

I've wanted this too; I rather like right-arrow for that. Perhaps we can show it as a placeholder in a lower-contrast color in the text box, too?

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 26, 2021
@Don-Vito
Copy link
Contributor

Don-Vito commented Aug 27, 2021 •
edited
Loading

I can try to do it in the next few weeks
Actually, it looks trivial.

@Don-Vito Don-Vito mentioned this issue Aug 27, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 27, 2021
@ghost ghost closed this as completed in #11069 Aug 30, 2021
@ghost ghost removed the In-PR This issue has a related PR label Aug 30, 2021
ghost pushed a commit that referenced this issue Aug 30, 2021
@Don-Vito
Teach command palette to fill in selected commandline upon right arrow (
871b8de 
#11069)

Closes #11049
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 30, 2021
@zadjii-msft zadjii-msft removed the Needs-Discussion Something that requires a team discussion before we can proceed label Aug 30, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11069, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CmdPal Command Palette issues and features Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Teach command palette to fill in selected commandline upon right arrow Don-Vito/terminal
3 participants
@DHowett @Don-Vito @zadjii-msft